这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix: Create output directory recursively instead of silently failing to produce output #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2021
Merged

Fix: Create output directory recursively instead of silently failing to produce output #413

merged 2 commits into from
Apr 10, 2021

Conversation

@mprencipe
Copy link
Contributor

@mprencipe mprencipe commented Mar 16, 2021

Description

Output directory is now created recursively if the given directory path doesn't exist. Previously the output writing would silently fail in this case.

Fixes: #395

Additionally

  • If this is the first time you are contributing to ffuf, add your name to CONTRIBUTORS.md.
    The file should be alphabetically ordered.
  • Add a short description of the fix to CHANGELOG.md

Thanks for contributing to ffuf :)

@mprencipe mprencipe changed the title Fix issue 395 Fix: Create output directory recursively instead of silently failing to produce output Mar 16, 2021
@joohoi joohoi changed the base branch from master to dev April 10, 2021 12:01
joohoi
joohoi approved these changes Apr 10, 2021
View reviewed changes
Copy link
Member

@joohoi joohoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, LGTM!

@joohoi joohoi merged commit 8a9a075 into ffuf:dev Apr 10, 2021
joohoi pushed a commit that referenced this pull request Apr 18, 2021
@mprencipe @joohoi
Fix: Create output directory recursively instead of silently failing …
a513e27 
…to produce output (#413)

* Fix: Create output directory recursively instead of silently failing to write output. Fixes issue #395.

* Update changelog, contributors
joohoi pushed a commit that referenced this pull request Feb 3, 2023
@mprencipe @joohoi
Fix: Create output directory recursively instead of silently failing …
7cdc6fc 
…to produce output (#413)

* Fix: Create output directory recursively instead of silently failing to write output. Fixes issue #395.

* Update changelog, contributors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joohoi joohoi joohoi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create output dir recursively [essential when outputs parent folder does not exist)

2 participants

@mprencipe @joohoi