这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@jsgv
Copy link
Contributor

@jsgv jsgv commented Nov 10, 2020

This is a new pull request that replaces original pull request

  • Add flag to set the shell to be used for the the input command

This is in response to issue #141
Adds support to set the shell to be used with input-cmd. Fixes some issues that happen when using the default shell (/bin/sh). But still defaults to current shell if not set.

For example:
echo does not support -n flag in /bin/sh

Being able to set /bin/zsh or /bin/bash would fix the issue.

Usage:

ffuf -v \
    -input-shell "/bin/zsh" \
    -input-cmd 'echo -n subscriptions' \
    -input-num 1 -u https://example.com/path1/FUZZ

@jsgv jsgv mentioned this pull request Nov 10, 2020
Copy link
Member

@joohoi joohoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. If you could add a short description to CHANGELOG.md and yourself to CONTRIBUTORS.md (alphabetically sorted), it'd be great! Oh, and the README.md usage example would need to have the new option added to it as well :)

@jsgv jsgv requested a review from joohoi November 24, 2020 07:50
Copy link
Contributor Author

@jsgv jsgv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added updates to markdown files

@jsgv
Copy link
Contributor Author

jsgv commented Dec 16, 2020

Anything else? @joohoi

@joohoi
Copy link
Member

joohoi commented Jan 24, 2021

LGTM!

@joohoi joohoi merged commit 5b75e90 into ffuf:master Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants