这是indexloc提供的服务,不要输入任何密码
Skip to content

Add -timeout flag for customizable HTTP Request timeouts #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 27, 2019
Merged

Add -timeout flag for customizable HTTP Request timeouts #31

merged 7 commits into from
Apr 27, 2019

Conversation

lc
Copy link
Contributor

@lc lc commented Apr 25, 2019

Hi,

Like the title implies, this PR adds the command line flag -timeout which allows users to add a custom HTTP request timeout. I've had several use-cases for it recently so I figured I would add this.

By default, it is set to 10 seconds.

@lc lc changed the title Add -timeout flag for customizable HTTP Request timeouts Add -timeout flag for customizable HTTP Request timeouts Apr 25, 2019
@joohoi
Copy link
Member

joohoi commented Apr 26, 2019

Thanks for the PR! It's definitely a good feature to have, we discussed it recently in #4 with @SolomonSklash as well.

Copy link
Member

@joohoi joohoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you add a README.md entry under Changelog for this feature as well?

Add Changelog Entry
@lc
Copy link
Contributor Author

lc commented Apr 26, 2019

Added!

Copy link
Member

@joohoi joohoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this in the first round. And I'd love to see the new cli flag help text added to README.md "Usage" section as well.

@lc
Copy link
Contributor Author

lc commented Apr 27, 2019

Should be all good to go now

Copy link
Member

@joohoi joohoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution! I'll add the README.md Usage section changes later on.

@joohoi joohoi merged commit 752002d into ffuf:master Apr 27, 2019
SakiiR pushed a commit to SakiiR/ffuf that referenced this pull request Aug 28, 2019
* Add -timeout flag to specify HTTP request timeouts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants