-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add -timeout flag for customizable HTTP Request timeouts #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
-timeout
flag for customizable HTTP Request timeouts
Thanks for the PR! It's definitely a good feature to have, we discussed it recently in #4 with @SolomonSklash as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Could you add a README.md
entry under Changelog for this feature as well?
Add Changelog Entry
Added! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I missed this in the first round. And I'd love to see the new cli flag help text added to README.md
"Usage" section as well.
Should be all good to go now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution! I'll add the README.md
Usage section changes later on.
* Add -timeout flag to specify HTTP request timeouts
Hi,
Like the title implies, this PR adds the command line flag
-timeout
which allows users to add a custom HTTP request timeout. I've had several use-cases for it recently so I figured I would add this.By default, it is set to
10
seconds.