Increase default rows per page on html report #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously 10 results were displayed per-page, as the default of DataTables. This change increases the default to 250 results per page and also adds the option for 250, 500, 1000, 2500 and ALL results. In addition, materialize css default was blocking the viewing of the option to display alternative results per-page. This is resolved by calling .formSelect as per https://stackoverflow.com/questions/28258106/materialize-css-select-doesnt-seem-to-render Fixes ffuf#216 Signed-off-by: Dave Walker (Daviey) <email@daviey.com>
|
Thanks for the PR! This looks great! I tried to poke this exact issue before but didn't figure out a solution. I'll review this PR later today, but could you add entry to |
Signed-off-by: Dave Walker (Daviey) <email@daviey.com>
joohoi
reviewed
Apr 18, 2020
Signed-off-by: Dave Walker (Daviey) <email@daviey.com>
|
Hey this change isn't in v1.0.2 yet correct? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously 10 results were displayed per-page, as the
default of DataTables. This change increases the default to
250 results per page and also adds the option for 250, 500,
1000, 2500 and ALL results.
In addition, materialize css default was blocking the
viewing of the option to display alternative results
per-page. This is resolved by calling .formSelect as per
https://stackoverflow.com/questions/28258106/materialize-css-select-doesnt-seem-to-render
Fixes #216
Signed-off-by: Dave Walker (Daviey) email@daviey.com