Add a new argument -tls-version (Default 1.3) #833
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this PR address the keep-alive issues in #790 ? |
joohoi
requested changes
Apr 5, 2025
There was a problem hiding this comment.
Hi, thanks for your contribution. In general, this looks good, few minor things though:
- I think it would be a good idea to default to tls 1.3 instead of 1.0. There might be incompatibility issues along the way due to weird implementations and such, and defaulting to the latest version is probably what majority of the userbase would expect.
- Could you please run gofmt on the changed code to adhere to Go code formating standards in order to keep the commit history clean
|
Hey, I’ve made the changes as per your suggestion. Could you please take a look? |
|
@joohoi there are two issues in issue 790, keep-alive, and tls versions, is there any plan on adding the option to disable keep alive? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add a short description of pull request contents.
If this PR addresses an existing issue, please add the issue number below.
Fixes: #790
Additonally
CONTRIBUTORS.md.The file should be alphabetically ordered.
CHANGELOG.mdThanks for contributing to ffuf :)