Fixed Error for HTML Output #714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed Error for HTML Output [ERR] template: output.html:74:94: executing "output.html" at <$result.HTMLColor>: can't evaluate field HTMLColor in type output.htmlResult
joohoi
requested changes
Sep 12, 2023
Member
joohoi
left a comment
There was a problem hiding this comment.
I wasn't able to reproduce the issue, and the Go html/template does support using the tags in both ways: with and without the whitespaces, I doubt that this fix is actually related. However it's a good contribution to keep the coding style intact (spaces are used elsewhere in the template), so I'm going to merge it.
Could you please remove the CHANGELOG.md entry though, as this should not affect the actual template parsing.
joohoi
approved these changes
Sep 13, 2023
Member
joohoi
left a comment
There was a problem hiding this comment.
Nvm, I fixed the changelog entry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Error for HTML Output regarding template output.html
I kept getting the following error with -of html
[ERR] template: output.html:74:94: executing "output.html" at <$result.HTMLColor>: can't evaluate field HTMLColor in type output.htmlResult
This fix worked for me.
Closes #684