Fix Issue696 -- Divide by 0 Error when setting rate to 0 manually #700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de by 0 error when the rate is set to 0. Ref: issue 696: ffuf#696
…og.md as requested in PR doc
joohoi
reviewed
Sep 12, 2023
CONTRIBUTORS.md
Outdated
| * [TomNomNom](https://github.com/tomnomnom) | ||
| * [xfgusta](https://github.com/xfgusta) | ||
|
|
||
| * [Ephex2](https://github.com/Ephex2) |
Member
There was a problem hiding this comment.
Could you make this alphabetically sorted?)
joohoi
requested changes
Sep 12, 2023
Member
joohoi
left a comment
There was a problem hiding this comment.
One small change, otherwise LGTM!
Member
|
Ok, fixed the only small issue there was, thanks again for the PR, merging! |
joohoi
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added check to RateThrottle.ChangeRate() in rate.go to prevent a divide by 0 error when the rate is set to 0. Ref: issue 696: #696
Fixes: #696
Additionally
Name added to contributors.md as requested.
Change made to CHANGELOG.md may not be in the right place, please verify, I'm new here :)