This repository was archived by the owner on Mar 30, 2018. It is now read-only.
Add chaincode ping2#issue1850 #1957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi muralisrini, Thanks for submitting this pull request! Please add a comment with a DCO1.1 Signed-off-by statement in order to allow us to process your pull request. dco-bot |
peer/core.yaml
Outdated
| #keepalive in seconds. In situations where the communiction goes through a | ||
| #proxy that does not support keep-alive, this parameter will maintain connection | ||
| #between peer and chaincode. | ||
| #A value <= 0 turns keepalive off |
Contributor
There was a problem hiding this comment.
Could you add a space after the # characters so it is consistent with the other comments in core.yaml?
Contributor
|
Thanks, LGTM |
lhaskins
pushed a commit
to lhaskins/fabric-archive
that referenced
this pull request
Oct 14, 2016
…incode_ping2#issue1850 Add chaincode ping2#issue1850
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow a keep alive messages between fabric and chaincode. Default is no-keepalive.
Description
It is possible that an inactive gRPC connection between the chaincode and the peer can get broken by a intermediate proxy. Introduced a "keepalive" parameter (in seconds) which can be used to send ChaincodeMessage of type KEEPALIVE between the peer and chaincode. A chaincode just echoes the KEEPALIVE message received from the peer.
Motivation and Context
Keeps the connection between peer and chaincode going with application protocol level messages. This makes the connection liveness non dependent upon lower layer keepalive mechanisms.
Fixes #1850
How Has This Been Tested?
Enabled all chaincode tests (except one for covering no keep-alive scenario) to use an aggressive keepalive timer of 1 second.
Checklist:
The continuous integration build process will run make checks to confirm that tests pass and that code quality meets minimum standards. You may optionally run this locally as PRs will not be accepted until they pass.
Signed-off-by:muralisr@us.ibm.com