这是indexloc提供的服务，不要输入任何密码
Skip to content

Another Apple provider #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 54 commits into from
Jul 21, 2020
Merged

Another Apple provider #1178

merged 54 commits into from
Jul 21, 2020

Conversation

@sputnik73
Copy link
Contributor

@sputnik73 sputnik73 commented May 22, 2020

The main difference of this version is that users don’t need care about secret generation, and getUserProfile() returns all information Apple provides.

Additionally it handles token expiration (refresh token is not available in the Apple API). A leeway makes JWT validation more reliable.

The provider was discussed in issue #1095

sputnik73 and others added 30 commits May 8, 2020 02:48
@sputnik73
phpdoc declaration fixed
54cc66d
@sputnik73
Configurable encoding type for http_build_query calls
9909c40 
Sign in to apple requrires does not work with PHP_QUERY_RFC1738 encoded query strings but requires PHP_QUERY_RFC3986
@sputnik73
Apple provider class added
674f33a
@sputnik73
Documentation for requirements to use sign in with apple added
ab894a6
@sputnik73
Update APPLE.md
74a01bf 
Info about response_mode (query/post) corrected
@sputnik73
Update APPLE.md
be72f97 
Text update
@sputnik73
Update APPLE.md
402977d 
Linkebreaks added to links
@sputnik73
Example provided how to change the response_mode
d6b6c4e
@sputnik73
Update APPLE.md
8bcaeaa 
Text update
@sputnik73
getUserProfile() implemented using data from $_REQUEST
01552a7
@sputnik73
Create the secret from signed JWT
b4bdca2
@sputnik73
Outdated how-to text removed
871452f
@sputnik73
Requirement codercat/jwk-to-pem added to the documentation
6cec87f
@sputnik73
Validate token and extract the payload for user profile
df27f6e
@sputnik73
text update: secret must not be empty
d18bee4
@sputnik73
missing namespace alias for JWK added
a215e80
@sputnik73
optional simple token payload extraction without signature check
b10c93c
@sputnik73
fixed/added documentation about dependencies
fdf521f
@sputnik73
mention optional parameter verifyTokenSignature in the documentation
5e561b0
@sputnik73
Update APPLE.md
386e94e 
Dependencies hl level fixed
@sputnik73
Update APPLE.md
6d551bc 
hint where to sign in for keys/ids
@sputnik73
Update APPLE.md
3ecc51e 
copy/paste fixed
@sputnik73
Update APPLE.md
3f9491d 
Explain JWT
@sputnik73
Update APPLE.md
dcff235 
secret explanation updated in the documentation
@sputnik73
Update APPLE.md
63c7413 
documentation linebreak
@sputnik73
secret paragraph reformatted
9c9b481
@sputnik73
define apiBaseUrl
7d20944
@sputnik73
token handling moved to getrUserProfile(), improved public key handling
0676713
@sputnik73
define JWT::$leeway
55bc5d1
@sputnik73
Check if the token is expired in isConnected
8573f2b
@ApacheEx
Copy link
Member

ApacheEx commented Jun 17, 2020

thank you for all your hard work. I will have a look on it soon

@zorn-v
Copy link
Contributor

zorn-v commented Jul 7, 2020

What about possibility set key content instead of key file in options ? Maybe allow both variants (with priority for key_content).
Handle uploading of file for provider config maybe not so simple sometimes.

@sputnik73
Copy link
Contributor Author

sputnik73 commented Jul 7, 2020 •
edited
Loading

What about possibility set key content instead of key file in options ? Maybe allow both variants (with priority for key_content).

Thx for the suggestion. Agreed that might be useful and it's not much work, I will implement that.

@sputnik73 sputnik73 mentioned this pull request Jul 19, 2020
Closed
@ApacheEx ApacheEx mentioned this pull request Jul 21, 2020
Closed
@ApacheEx ApacheEx added this to the 3.4 milestone Jul 21, 2020
@ApacheEx ApacheEx linked an issue Jul 21, 2020 that may be closed by this pull request
Add support for "Sign In with Apple" #1095
Closed
ApacheEx
ApacheEx approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@ApacheEx ApacheEx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is perfect. Looks amazing for me. Yes, there are some extra composer dependencies, but I think it's fine. Thank you

@ApacheEx
Copy link
Member

ApacheEx commented Jul 21, 2020

I've moved Apple.md to https://github.com/hybridauth/hybridauth.github.io (it's available here: https://hybridauth.github.io/providers/apple.html)

@ApacheEx ApacheEx merged commit 39a44bf into hybridauth:master Jul 21, 2020
@sputnik73
Copy link
Contributor Author

sputnik73 commented Jul 21, 2020

this one is perfect. Looks amazing for me. Yes, there are some extra composer dependencies, but I think it's fine. Thank you

Thank you for the great feedback and for merging. Any suggestions for improvement are welcome of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ApacheEx ApacheEx ApacheEx approved these changes

Assignees

No one assigned

Labels

tag: new feature 🚀 tag: provider 🏠

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

Add support for "Sign In with Apple"

3 participants

@sputnik73 @ApacheEx @zorn-v