这是indexloc提供的服务，不要输入任何密码
Skip to content

try using noble #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 62 commits into from
Dec 28, 2024
Merged

try using noble #7

merged 62 commits into from
Dec 28, 2024

Conversation

@tarasglek
Copy link
Collaborator

@tarasglek tarasglek commented Nov 3, 2024 •
edited
Loading

  • Switch to noble which involves doing path-validation
  • get rid of buffer.
  • keep unencrypted secrets.json in test so it's easier to modify/test
  • use faster prettier@next
  • disable INI tests, cos INIs are a mess in SOPS

@tarasglek tarasglek changed the title try using nobile to fix #4 try using noble Nov 3, 2024
@tarasglek
fix: Add documentation comment for keyPath option in DecryptOptions
22d67ca
@tarasglek
docs: Convert DecryptOptions comments to TSDoc format
c875ef9
@tarasglek
plumb path through
c120f03
@tarasglek
feat: Add Noble cipher implementation for SOPS-style AES256_GCM encry…
4ba1da6 
…ption and decryption
@tarasglek
refactor: Split decrypt function into base and convenient implementat…
0211926 
…ions
@tarasglek
refactor: Separate decryption and type conversion in decrypt functions
0758d40
@tarasglek
feat: Add EncryptedData and ParsedEncryptedData interfaces for better…
90c21d5 
… type safety
@tarasglek
refactor: Uncomment and integrate encrypt method into cipher-noble im…
9b6fce5 
…plementation
@tarasglek
refactor: Separate encrypt core logic from SOPS format handling
cdfaba4
@tarasglek
refactor: Reorganize cipher-noble.ts with code cleanup and type impro…
9117907 
…vements
@tarasglek
refactor: Simplify error message conversion using String() instead of…
8cd1c78 
… toString()
@tarasglek
refactor: Rename decryptConvenient to decryptSOPS and use Number methods
8703347
@tarasglek
refactor: Extract datatype conversion into separate function
7745691
@tarasglek
feat: Add SOPSDataType enum for type-safe SOPS data handling
6397efd
@tarasglek
refactor: Reorder enum values and update type conversion function
00608cc
@tarasglek
docs: Add JSDoc comments to cipher functions
cdcc86b
@tarasglek
refactor: Update decrypt function documentation comment
899929e
@tarasglek
refactor: Make additionalData a required parameter in decryption fu…
73993d8 
…nctions
@tarasglek
refactor: Update decrypt function signature and parameter handling
6ea69d8
@tarasglek
refactor: Move UTF-8 conversion from decrypt to decryptSOPS
9ef1725
@tarasglek
refactor: Extract path conversion logic into path2gopath utility fu…
81d133d 
…nction
@tarasglek
refactor: Reorder comments and clean up whitespace in decrypt.ts
6ad3580
@tarasglek
refactor: Improve error handling in decryptValue with detailed error …
ce6e0a5 
…message
@tarasglek
load unencrypted json from file
6951db0
@tarasglek
refactor: Reorder isEmpty function and remove unnecessary blank line
e58ac99
@tarasglek
refactor: Add type annotation to isEmpty function
0a27743
@tarasglek
refactor: Remove isEmpty function and simplify empty check in decrypt…
262a1e6 
…SOPS
@tarasglek
refactor: Replace Noble Ciphers utils with TextEncoder/TextDecoder
d3a324d
@tarasglek
get ready for moving funcs
68309f3
@tarasglek
refactor: Rename decrypt to decryptAesGcm for clarity and precision
15f191f
@tarasglek
refactor
e23452c
@tarasglek
refactor: Consolidate decryption functions into single `decryptSOPSVa…
401461e 
…lue`
@tarasglek
refactor: Remove commented-out decryptSOPS function implementation
941917c
@tarasglek
typo
d36451f
@tarasglek
refactor: Move and update comment for decryptSOPSValue function
3a0d948
@tarasglek
docs: Improve documentation for decryptSOPSValue function
b6e0dcb
@tarasglek
fix: Correct minor documentation formatting in decrypt function
2074ed7
@tarasglek
fix: Add error handling for AES-GCM decryption with detailed error me…
95f2926 
…ssage
@tarasglek
fix: Add explicit Uint8Array typing for decrypted variable in decrypt…
746b1e7 
…SOPSValue
@tarasglek
refactor: Simplify error handling and structure in decryptSOPSValue f…
97713b6 
…unction
@tarasglek
docs: Add comprehensive JSDoc documentation for decrypt() function
408807f
@tarasglek
jsdoc
c847b69
@tarasglek
format
010fe24
@tarasglek
refactor: Improve type safety for datatype exhaustive check in conver…
39c16d9 
…tDecryptedValue
@tarasglek
simpler
cba7d33
@tarasglek tarasglek requested a review from humphd December 25, 2024 10:34
@humphd
Copy link
Owner

humphd commented Dec 28, 2024

This looks great, thanks for all the work. I made a few changes:

  • dropped use of TS enum, which isn't as compatible as literals + a type-guard function
  • new version of Prettier isn't compatible with typescript-eslint, and trying to update it caused a cascade or problems. I've dropped eslint and typescript-eslint completely and switched to https://oxc.rs/
  • dropped support for INI files completely
  • used TS imports for JSON vs. readfile and JSON.parse
  • renaming

@humphd humphd merged commit 80ab2ee into main Dec 28, 2024
7 checks passed
@humphd humphd deleted the taras/only branch December 28, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@humphd humphd Awaiting requested review from humphd

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tarasglek @humphd