这是indexloc提供的服务,不要输入任何密码
Skip to content

Refactor and Provide a way to disable TLS 1.3 on connectionsFactory a… #7613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

WuonParticle
Copy link
Contributor

@WuonParticle WuonParticle commented May 16, 2025

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • Tests all pass
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
This PR introduces the ability to disable TLS 1.3 in the ConnectionsFactory class to address compatibility issues with VPNs that may block TLS 1.3 connections. Key changes include:

  • Refactored to a proper singleton pattern to avoid class attribute shadowing by instance attributes
  • Added a set_disable_tls_1_3() method to toggle TLS 1.3 support.
  • Modified _get_shared_client() to use TLSv1.2 when TLS 1.3 is disabled.
  • Ensured proper cleanup of client sessions when TLS settings change.

Tests performed by the developer:

  • Added comprehensive unit tests for the new functionality.
  • Verified backward compatibility with existing connections.
  • Tested manually with openVPN setup that previously had issues with TLS 1.3.

Tips for QA testing:

  • Verify that existing connections (without TLS 1.3 disabled) remain unaffected.
  • Check for any performance impact (or just verify it works) when TLS 1.3 is disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant