这是indexloc提供的服务，不要输入任何密码
Skip to content

Feat/enhance controllers config management #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
Jun 21, 2024
Merged

Feat/enhance controllers config management #143

merged 36 commits into from
Jun 21, 2024

Conversation

@cardosofede
Copy link
Contributor

@cardosofede cardosofede commented Jun 10, 2024

No description provided.

@nikspz nikspz requested review from nikspz and rapcmia June 17, 2024 11:16
@rapcmia rapcmia mentioned this pull request Jun 17, 2024
Merged
@rapcmia
Copy link
Contributor

rapcmia commented Jun 18, 2024 •
edited
Loading

After successfully setup with PR15, the Portfolio page returns error of streamlit.errors.StreamlitAPIException: Every Multiselect default value must exist in options which is different from want we see on cardosofede/hummingbot-deploy main version.

image

2024-06-18 12:24:28.660 Uncaught app exception
Traceback (most recent call last):
  File "/Users/rapcomia/miniconda3/envs/dashboard/lib/python3.10/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 584, in _run_script
    exec(code, module.__dict__)
  File "/Users/rapcomia/github/dashboard/143/frontend/pages/orchestration/portfolio/app.py", line 87, in <module>
    tokens_available = st.multiselect("Select Tokens", set(tokens_available), set(tokens_available))
  File "/Users/rapcomia/miniconda3/envs/dashboard/lib/python3.10/site-packages/streamlit/runtime/metrics_util.py", line 397, in wrapped_func
    result = non_optional_func(*args, **kwargs)
  File "/Users/rapcomia/miniconda3/envs/dashboard/lib/python3.10/site-packages/streamlit/elements/widgets/multiselect.py", line 249, in multiselect
    return self._multiselect(
  File "/Users/rapcomia/miniconda3/envs/dashboard/lib/python3.10/site-packages/streamlit/elements/widgets/multiselect.py", line 292, in _multiselect
    indices = _check_and_convert_to_indices(opt, default)
  File "/Users/rapcomia/miniconda3/envs/dashboard/lib/python3.10/site-packages/streamlit/elements/widgets/multiselect.py", line 92, in _check_and_convert_to_indices
    raise StreamlitAPIException(
streamlit.errors.StreamlitAPIException: Every Multiselect default value must exist in options

@nikspz
Copy link
Contributor

nikspz commented Jun 20, 2024

@cardosofede Could you please fix branch conflicts here?

@rapcmia
Copy link
Contributor

rapcmia commented Jun 21, 2024

PR update:

After successfully setup with PR15, the Portfolio page returns error of streamlit.errors.StreamlitAPIException: Every Multiselect default value must exist in options which is different from want we see on cardosofede/hummingbot-deploy main version.

  • This behavior happened on latest version as well so not related to the PR
  • Successfully setup with PR15, hummingbot-broker and using dardonacci/hummingbot:latest
  • Create, delete and add accounts/credentials ok
  • Create, modified, add and delete controller configs ok
  • Setup pmm_simple using mexc as connector monitoring, to add updates later
  • Ran few endpoints from ..:8000/docs

Approved but PR needs fixin on branch conflicts

cardosofede added 23 commits June 21, 2024 12:08
@cardosofede
(feat) rename deploy page
9dfa3e3
@cardosofede
(feat) add delete controllers feature and simplify box
7db22e8
@cardosofede
(feat) add route to simplify backend api
530db31
@cardosofede
(feat) add random name generator
4add30d
@cardosofede
(feat) adapt bollinger v1 to random names
1ca8d99
@cardosofede
(feat) adapt macd bb to random names
5c2c0cc
@cardosofede
(feat) adapt supertrend to random names
4e156f4
@cardosofede
(feat) improve loaders and save config
00b452e
@cardosofede
(feat) improve units for custom spreads
fdacbe9
@cardosofede
(feat) add random generator of names for configs
e908543
@cardosofede
(feat) update default configs in pages
aa9e137
@cardosofede
(feat) add version
15f6ab0
@cardosofede
(feat) improve loaders and config savers
62e0f29
@cardosofede
(feat) restore it if is a different controller name
9cb1a9c
@cardosofede
(feat) improve response of is docker running
8ec3098
@cardosofede
(feat) add method to get the instance of hte backend api with error h…
5adf7df 
…andling
@cardosofede
(feat) adapt components to get backend api client
275b87d
@cardosofede
(feat) adapt pages to get the backend api client
04dc8a7
@cardosofede
(feat) make the keys password type
39f23a5
@cardosofede
(feat) handle credentials connection error
23e83d8
@cardosofede
(feat) improve performance card and add logs
7ac69bb
@cardosofede
(feat) remove rerun from submit credentials
0ac8edd
@cardosofede
(feat) adapt changes to config version
8a67b44
@cardosofede cardosofede force-pushed the feat/enhance_controllers_config_management branch from f6993ba to 7f5a58c Compare June 21, 2024 11:11
@cardosofede cardosofede merged commit be50f01 into main Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rapcmia rapcmia rapcmia approved these changes

@nikspz nikspz Awaiting requested review from nikspz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cardosofede @rapcmia @nikspz