cleaned up gitignore and edited readme #11
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fengtality
commented
Apr 27, 2023
- gitignore - removed unused content and added entries
- added more instructions to README
- added instructions for users to symlink Hummingbot data directory
Contributor
Author
|
Added a commit that fixes #12 |
cardosofede
reviewed
May 9, 2023
Contributor
cardosofede
left a comment
There was a problem hiding this comment.
@fengtality the gitignore is the standard for Python that Github provides and probably is good in case that someone builds the project locally, creates notebooks to check things, and so...
The improvements in the docs are good, do you want to create a new PR with the cleanups of the docs?
Contributor
Author
Sure, will do |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.