update bnb token list #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rapcmia
approved these changes
May 3, 2023
fengtality
requested changes
May 3, 2023
Contributor
fengtality
left a comment
There was a problem hiding this comment.
Approved subject QA testing that the top tokens on BNB Chain (WBNB, USDT, USDC, CAKE) don't have any duplicate entries in this list, since if there are duplicates, the token symbol may resolve to the incorrect address.
fengtality
approved these changes
May 3, 2023
Contributor
Confirmed no duplicate and token symbols and address are correct 💯 |
Contributor
|
Merged to development and will be available on hummingbot version 1.16.0 |
This was referenced May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
This pr updates the BNB token list with data from the token list used by Pancakeswap - https://tokens.pancakeswap.finance/pancakeswap-extended.json
Tests performed by the developer:
Tips for QA testing: