这是indexloc提供的服务,不要输入任何密码
Skip to content

Feat/make dexalot api key optional #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vic-en
Copy link
Collaborator

@vic-en vic-en commented Apr 28, 2023

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
This pr deprecates Dexalot's api key.
[ch39631]

Tests performed by the developer:

  • Reconnecting Dexalot connector.

Tips for QA testing:

@vic-en vic-en reopened this May 3, 2023
@vic-en vic-en changed the base branch from main to development May 3, 2023 00:29
@vic-en vic-en changed the title Feat/deprecate dexalot api key Feat/make dexalot api key optional May 3, 2023
@vic-en vic-en mentioned this pull request May 3, 2023
2 tasks
@nikspz nikspz requested a review from fengtality May 3, 2023 05:57
Copy link
Contributor

@nikspz nikspz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests performed:
Connected dexalot successfully without using dexalot API key
Ran pureMM strategy using dexalot

@fengtality fengtality merged commit 6d7b639 into hummingbot:development May 5, 2023
@fengtality fengtality deleted the feat/deprecate_dexalot_api_key branch May 5, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants