-
-
Notifications
You must be signed in to change notification settings - Fork 246
Feat/stonfi #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
hudson-oliveira-funttastic
wants to merge
208
commits into
hummingbot:development
from
robotter-ai:feat/stonfi
Closed
Feat/stonfi #385
hudson-oliveira-funttastic
wants to merge
208
commits into
hummingbot:development
from
robotter-ai:feat/stonfi
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added new dependencies: - @coral-xyz/anchor (v0.29.0) - @jup-ag/api (v6.0.29) - @solana/spl-token (v0.4.8) - @solana/spl-token-registry (v0.2.4574) - @solana/web3.js (v1.95.8) - @solflare-wallet/utl-sdk (v1.4.0) - Updated existing dependencies: - @ton/core (v0.59.0) - Resolved package versions in yarn.lock to use yarnpkg registry for consistency. - Added resolution for @ston-fi/api/web3-utils (v1.8.2).
- Commented out the validateTonBalanceRequest function in TonController. - Updated the getAccount method in the Ton class to use mnemonicNew for account retrieval. - Adjusted the getAccount and getNativeBalance methods to improve account handling and balance retrieval. - Ensured consistency in using account addresses and public keys across methods.
- Updated TonController to use account.address instead of account.publicKey for balance retrieval. - Cleaned up the getAccount method in the Ton class by removing commented code and unnecessary blank lines. - Ensured consistent handling of account addresses across methods.
- Changed method to get account from address in TonController. - Updated balance retrieval to use account.publicKey instead of account.address for both native and asset balances. - Improved consistency in account handling across the controller.
- Deleted the ston_fi.test.ts file, which contained extensive test cases for the Stonfi connector. - This removal streamlines the test suite and eliminates outdated or redundant tests, contributing to a cleaner codebase.
- Modified the userWalletAddress assignment to fallback to the account variable if the wallet address is not available, enhancing robustness in transaction parameters. - Cleaned up logging statements for better readability by adjusting string concatenation. - Removed the outdated ston_fi test file to streamline the test suite and eliminate redundancy, contributing to a cleaner codebase.
ton.controller.test.ts
- Updated userWalletAddress assignment to use account variable as a fallback, improving robustness in transaction parameters. - Cleaned up logging statements for better readability. - Removed outdated ston_fi.test.ts file to streamline the test suite and eliminate redundancy, contributing to a cleaner codebase.
…dations - Deleted the ton.test.ts file, which contained extensive test cases for the Ton class, streamlining the test suite. - Added new validation functions for network and address parameters in ton.validators.ts, improving input validation. - Updated existing validators to export them for better accessibility in tests. - Introduced a new test suite for ton.validators, ensuring comprehensive coverage of validation logic.
- Reformatted import statements in ston_fi.ts for consistency. - Simplified the random number generation logic in the Stonfi class. - Deleted the ton.routes.test.ts file, which contained extensive test cases for the Ton class, streamlining the test suite and eliminating redundancy.
…ve unused methods - Added wallet contract retrieval functionality based on versioning in the Ton class. - Introduced a new method to get account details from a mnemonic phrase. - Removed the outdated getLatestTransactionHash method to streamline the codebase. - Added comprehensive tests for new functionalities, including wallet contract retrieval and account handling. - Enhanced existing tests for better coverage and clarity.
- Updated TODO comments for consistency in the Ton class, ensuring all comments are formatted uniformly. - No functional changes were made; this commit focuses on code readability and maintainability.
… and renaming test descriptions - Removed unused wallet contract imports from ton.test.ts to streamline the code. - Renamed the 'Initialization' describe block to 'init' for clarity and consistency in test naming. - No functional changes were made; this commit focuses on improving test organization and readability.
- Introduced a new test suite for the getBestWallet method, ensuring it correctly identifies the wallet with the highest native token balance. - Mocked wallet contract classes and client methods to simulate wallet creation and balance retrieval. - Enhanced test coverage for wallet handling functionality in the Ton class.
…e test - Added a newline at the end of the file for proper formatting. - Confirmed that the precision check for the getNativeBalance method remains intact, ensuring the test accurately validates the expected balance with 9 decimal precision.
- Removed outdated TODO comments in the Ton class for improved clarity. - Added a new utility function in tests to validate mnemonic input and return mock keys. - Enhanced test coverage for the getWallet and getTransaction methods, ensuring proper handling of event hashes and wallet retrieval. - Streamlined the test suite by consolidating duplicate code and improving organization.
- Updated the promiseAllInBatches function to return the result of the task execution instead of awaiting it directly. - Simplified logging in runWithRetryAndTimeout by removing unnecessary line breaks. - Removed a redundant test case for timeout error in ton.controller.test.ts. - Added new tests in ton.test.ts for getCurrentBlockNumber, error handling in getAssetBalance, and instance management in getInstance. - Renamed the 'Initialization' describe block to 'init' for consistency and clarity in test naming.
…dling - Added new test cases for error handling in wallet version retrieval and encryption/decryption methods. - Implemented tests for handling empty wallet versions and JSON parse errors in asset data retrieval. - Improved test coverage for the getAssetForSymbol method, ensuring it returns null for non-existent symbols. - Updated existing tests for better clarity and organization, including a new test suite for additional Ton class functionalities.
- Updated mock implementations for balance retrieval in ton.test.ts to enhance clarity and maintain consistency. - Ensured that the test cases for wallet balance accurately reflect the expected values for different wallet versions.
- Added tests for the close method to ensure it does not throw errors when called. - Improved error handling in getWalletContractClassByVersion for unsupported wallet versions. - Enhanced the getNativeBalance method tests to cover valid address retrieval, error scenarios, and precision checks. - Implemented a test for handling invalid state responses in waitForTransactionByMessage. - Consolidated and organized test cases for better clarity and maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are adding a new connector for stonfi.
The manual and automated tests are passing: