(fix) create multiple containers with same image #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengtality
approved these changes
Feb 21, 2023
Contributor
fengtality
left a comment
There was a problem hiding this comment.
LGTM - tested by creating 2 Docker containers.
Notes for QA:
- second container needs to have a different name like
gateway2. This is expected behavior - When starting the 2nd container, the log message still prints the old ports (15888, 8080), but the actual ports on host machine are different. This is a bug that we should fix down the road.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Fix gateway-create.sh file to allow users create multiple instances of the gateway
Tests performed by the developer:
Tips for QA testing: