Feat/openocean updates #32
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengtality
reviewed
Feb 21, 2023
Contributor
fengtality
left a comment
There was a problem hiding this comment.
Closing this one in favor of #34
| token.symbol, | ||
| token.name | ||
| ); | ||
| if (process.env.NODE_ENV === 'production') { |
Contributor
There was a problem hiding this comment.
there is no NODE_ENV variable, so this will never get called
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
GatewayV2 openocean.finance exchange added ethereum, harmony, polygon 3 chains again
Tests performed by the developer:
Write and pass unit tests, postman executes price and trade interface tests, and completes trade on-chain transactions
Tips for QA testing: