Uniswap - add avalanche chain/network to the current Uniswap connector #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 26, 2024
Closed
Contributor
Author
|
is there an issue with the pr @nikspz? |
Contributor
Hmm I think It should be |
Contributor
Author
|
Either ways Avalanche is EVM compatible... in this context it should still work as expected. Made modifications to use Avalanche chain instead @nikspz |
Contributor
Author
|
made a clean-up @nikspz it should be good for a review now |
f93435f to
8185014
Compare
Contributor
Author
|
Just a reminder and check if there is anything more I needed to do here @nikspz |
Contributor
|
Incorporated into #342 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
Your code builds clean without any errors or warnings
You are using approved title ("feat/", "fix/", "docs/", "refactor/")
A description of the changes proposed in the pull request:
Tests performed by the developer:
Test performed:
Set up gateway successfully
connected uniswap ethereum Avalanche successfully
check wallet now showing on gateway connect command
check gateway balance show balance for the ethereum cello wallet
curl test
chain/status: ok
/chain/balances: ok
/chain/allowance: ok
add/ remove wallet: ok
/amm/price: ok
Tips for QA testing: