这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@fengtality
Copy link
Contributor

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

This removes non-Ethereum network tests run in the standard coverage tests

@fengtality fengtality requested review from nikspz and vic-en April 17, 2024 22:55
@fengtality fengtality mentioned this pull request Apr 17, 2024
2 tasks
Copy link
Collaborator

@vic-en vic-en left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vic-en
Copy link
Collaborator

vic-en commented Apr 18, 2024

This fixes the failing test for now. It manages to eliminate the network that is causing the workflow to fail.
Only Goerli is patched in the workflow file, that is why this fix will always run deterministiscally.
Ideally, all network that is being referenced in any of the test files in ./test should also be patched so they can run deterministically with no issues in the future.

Copy link
Contributor

@nikspz nikspz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test performed:

  • Cloned and installed latest development and gwPR311
  • Connected with gateway ONLINE
  • connected the uniswap ethereum mainnet, arbitrum, polygon mainnet, avalanche succesfully

@fengtality fengtality merged commit a161ee4 into development Apr 18, 2024
@fengtality fengtality deleted the fix/remove-tests branch April 18, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants