(feat) pancakeswap mainnet #299

isreallee82 · 2024-03-20T17:54:24Z

Before submitting this PR, please make sure:

Your code builds clean without any errors or warnings
You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
Added functionalities to enable interaction with Pancakeswap on the Ethereum mainnet.
Ensured compatibility and seamless integration with the existing Pancakeswap connector architecture.
Implemented appropriate handling for chain-specific differences and features.

Tests performed by the developer:
curl test

Tips for QA testing:
curl test

isreallee82 · 2024-03-21T12:06:33Z

Good for a review now @nikspz

nikspz

Test performed:

Cloned and installed latest development branch and gwPR299
Set up gateway successfully
connected pancakeswap ethereum mainnet successfully
check wallet now showing on gateway connect command
check gateway balance show balance for the ethereum mainnet wallet
curl
- chain/status: ok
- /chain/balances
- add/ remove wallet: ok
- /amm/price: ok

notion-workspace · 2024-03-29T14:10:02Z

Pancakeswap adding ethereum

isreallee82 · 2024-04-01T01:06:17Z

Good for a review now @nikspz

nikspz · 2024-04-02T08:58:40Z

Test performed:

Cloned and installed latest development branch and gwPR299
Set up gateway successfully ✔
connected pancakeswap ethereum mainnet successfully✔
connected pancakeswap ethereum arbitrum successfully ✔
Failed to connect zkSync ❌
connected wallets now showing on gateway connect command ✔
gateway balance show balance for the ethereum mainnet and arbitrum ✔
created amm_arb using pancakeswap_ethereum_arbitrum ✔
Failed to gateway approve-tokens for pancakeswap_ethereum_arbitrum ❌
Approved manually using pancakeswap exchange, https://arbiscan.io/tx/0x4530aa8c2591b69967c1437ccc604e727e927987702992a2388b1546c86421bb https://arbiscan.io/tx/0x0936c97fbbde795d4df03cc60d618e1dbe49924e6850235f00bc970ff9f6d68d
Review tokens not mark as approved in client (gateway balance not showed allowances) ❌
Failed to start amm_arb startegy using pancakeswap_ethereum_arbitrum ❌

gw299.zip

logs_pancake_arbiturm.log
logs_gateway_app.log.2024-04-02.log

logs_hummingbot.log

isreallee82 · 2024-04-02T21:13:36Z

I will make a few test @nikspz will give you heads up if things runs fine possibly by end of tomorrow.

isreallee82 · 2024-04-04T04:13:50Z

fixed @nikspz

nikspz · 2024-04-04T19:45:20Z

commit [e812844](e812844)
- Test performed:
  - cloned and installed development + gwPR299
  - connected pancakeswap_ethereum_arbitrum
  - check balance succesfully
  - ~~Failed to~~ approved token using gateway approve-tokens pancakeswap_ethereum_arbitrum WETH

created/started amm_arb strategy using pancakeswap_ethereum_arbitrum
- price query failed: Cannot find a valid swap

logs_gateway_app.log.2024-04-04.log
logs_conf_amm_arb_1.log
logs_hummingbot.log

Error on POST https://localhost:15888/amm/price Error: {'message': 'Price query failed: Cannot find a valid swap route', 'httpErrorCode': 500

isreallee82 · 2024-04-04T22:52:52Z

sorry pancakeswap doc havent be updated, I see this have to do with subgraph api, I just noticed it was on their GitHub will push in a min @nikspz

isreallee82 · 2024-04-04T22:56:29Z

that should solve the price query error @nikspz

nikspz · 2024-04-05T14:07:12Z

Still failing @isreallee82

Test performed:
cloned and installed development + gwPR299
connected pancakeswap_ethereum_arbitrum
check balance succesfully
Created/started amm_arb using pancakeswap_ethereum_arbitrum
Review

logs_gateway_app.log.2024-04-05.log

logs_conf_amm_arb_1.log
logs_hummingbot.log

isreallee82 · 2024-04-05T18:17:31Z

I just change the endpoints to the second one provided @nikspz, also tested it against pairs available on arbitrum network. https://pancakeswap.finance/info/v3/arb/pairs, https://pancakeswap.finance/info/arb/pairs

isreallee82 · 2024-04-06T18:56:45Z

what market pair are you using @nikspz

nikspz · 2024-04-08T05:33:43Z

what market pair are you using @nikspz

WETH-USDC

isreallee82 · 2024-04-08T09:35:36Z

With curl test all seem to work fine @nikspz can you try with last push.

nikspz · 2024-04-09T19:03:57Z

logs_gateway_app.log.2024-04-09.log
logs_pancake-arb.log

Curl:

chain/tokens : ok
amm/price: had instances when able to check price, then failing @isreallee82

Note: Not usable for amm_arb, will discuss and check to finalize PR

isreallee82 · 2024-04-10T14:34:07Z

Alright @nikspz, Also I guess the subgraph is api rate limited, made a clean-up on the pr for instances of chain preventing more iterations, no change in functionality, I will await your feedback

to discuss what to do this the amm/price issue

nikspz

commit e7e3146
- Connected zksync succesfully
- connected arbitrum succesfully
- added connector-tokens
- checked pancakeswap gateway balance succesfully
- amm/price shows price then Failed for amm_arb strategy after ~5-10 sec after start
- curl
  - wallet/add
    - arbitrum, mainnet, zksync: ok
  - amm/price pancakeswap ethereum
    - arbitrum: ok
    - zksync: ok
    - mainnet: ok
  - amm/trade
    - arbitrum: ok
      https://arbiscan.io/tx/0x75361012061d13c640babb649a2b8ac241558b51f15138566c5a9aa595db9e71
  - amm/liquidity/add: ok https://arbiscan.io/tx/0x6a9fe1d7631ab17015dcb0d30697f5ebf2e261bc82d1cc933e860c4d3a539b8d

Note: There's still cases of amm/price failing when using amm_arb strategy using pancakeswap arbitrum

rapcmia · 2024-04-15T03:14:15Z

Merged to development and part of release version 1.27.0

notion-workspace · 2024-04-22T12:55:19Z

(feat) pancakeswap mainnet #299

(feat) pancakeswap mainnet

3da3d35

isreallee82 mentioned this pull request Mar 20, 2024

Pancakeswap - add Ethereum Mainnet, arbitrum and zkSync for current Pancakeswap connector hummingbot/hummingbot#6912

Closed

(feat) pancakeswap mainnet

f8a9222

nikspz linked an issue Mar 21, 2024 that may be closed by this pull request

Pancakeswap - add Ethereum Mainnet, arbitrum and zkSync for current Pancakeswap connector hummingbot/hummingbot#6912

Closed

(fix) eth subgraph

907cde5

nikspz requested review from fengtality and nikspz March 27, 2024 13:47

Merge branch 'development' into feat/pancakeswap_mainnet_chain

76d8007

nikspz previously approved these changes Mar 29, 2024

View reviewed changes

isreallee82 added 4 commits March 30, 2024 20:06

(clean-up) uniswap test file

3e13b19

(feat) arbitrum

1c9a077

(feat) zksync

ea22760

(feat) ethereum_zksync integration

765a118

(refactor) Added arbitrum and zksync router addressess

c17fe52

isreallee82 added 2 commits April 4, 2024 02:53

(refactor) fix zksync connection

f57de40

(feat) approve tokens for pancakeswap ethereum chain

e812844

(feat) arbitrum subgrph api

109a98d

(feat) arbitrum studio subgrph api

6640380

(clean-up) dynamic chain instances

7a6ec9d

fengtality approved these changes Apr 10, 2024

View reviewed changes

Merge branch 'development' into feat/pancakeswap_mainnet_chain

e7e3146

nikspz approved these changes Apr 11, 2024

View reviewed changes

rapcmia merged commit 343793c into hummingbot:development Apr 15, 2024

rapcmia mentioned this pull request Apr 25, 2024

sync gateway / staging -> master for Hummingbot gateway version 1.27.0 #315

Merged

2 tasks

Uh oh!

(feat) pancakeswap mainnet #299

(feat) pancakeswap mainnet #299

Uh oh!

Conversation

isreallee82 commented Mar 20, 2024

Uh oh!

isreallee82 commented Mar 21, 2024

Uh oh!

nikspz left a comment

Choose a reason for hiding this comment

Uh oh!

notion-workspace bot commented Mar 29, 2024

Uh oh!

isreallee82 commented Apr 1, 2024

Uh oh!

nikspz commented Apr 2, 2024

Uh oh!

isreallee82 commented Apr 2, 2024

Uh oh!

isreallee82 commented Apr 4, 2024

Uh oh!

nikspz commented Apr 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

isreallee82 commented Apr 4, 2024

Uh oh!

isreallee82 commented Apr 4, 2024

Uh oh!

nikspz commented Apr 5, 2024

Uh oh!

isreallee82 commented Apr 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

isreallee82 commented Apr 6, 2024

Uh oh!

nikspz commented Apr 8, 2024

Uh oh!

isreallee82 commented Apr 8, 2024

Uh oh!

nikspz commented Apr 9, 2024

Uh oh!

isreallee82 commented Apr 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nikspz left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rapcmia commented Apr 15, 2024

Uh oh!

notion-workspace bot commented Apr 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nikspz commented Apr 4, 2024 •

edited

Loading

isreallee82 commented Apr 5, 2024 •

edited

Loading

isreallee82 commented Apr 10, 2024 •

edited

Loading

nikspz left a comment •

edited

Loading