(feat) copy lists upon startup #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@fengtality This pr is still incomplete. Changes in last closed pr are needed. |
Contributor
Author
|
why is it incomplete?
…On Sat, Jul 15, 2023, 11:51 PM vic-en ***@***.***> wrote:
@fengtality <https://github.com/fengtality> This pr is still incomplete.
Changes in last closed pr are needed.
—
Reply to this email directly, view it on GitHub
<#160 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANWHVTP5MW6PBUC4BYGR4DXQOFNNANCNFSM6AAAAAA2LSAPGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Collaborator
The other changes to the package.json file is not included. |
Contributor
Author
|
Oh I see - actually these changes should remove the need for the changes to
package.json. I talked to Martin about this and he agreed that this
approach is better than modifying the yarn build command in package.json
…On Sun, Jul 16, 2023, 4:12 PM vic-en ***@***.***> wrote:
why is it incomplete?
… <#m_-4683235666114387238_>
On Sat, Jul 15, 2023, 11:51 PM vic-en *@*.*> wrote: @fengtality
<https://github.com/fengtality> https://github.com/fengtality
<https://github.com/fengtality> This pr is still incomplete. Changes in
last closed pr are needed. — Reply to this email directly, view it on
GitHub <#160 (comment)
<#160 (comment)>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANWHVTP5MW6PBUC4BYGR4DXQOFNNANCNFSM6AAAAAA2LSAPGY
<https://github.com/notifications/unsubscribe-auth/AANWHVTP5MW6PBUC4BYGR4DXQOFNNANCNFSM6AAAAAA2LSAPGY>
. You are receiving this because you were mentioned.Message ID: @.*>
The other changes to the package.json file is not included.
—
Reply to this email directly, view it on GitHub
<#160 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANWHVW4AML4BKDBB5LM2JDXQRYMRANCNFSM6AAAAAA2LSAPGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
rapcmia
approved these changes
Jul 17, 2023
Contributor
rapcmia
left a comment
There was a problem hiding this comment.
LGTM
- Build docker image for this PR
- Run docker compose file to create docker container
- Deleted
gateway_filesfolder and run compose file again ✅ - Checking
conf/listsagain, tokenlist.json files are available - Setup gateway connection, all ok
- Observed that the
tokenListSourcedir is now working 💯
- Observed that the
- Deleted
- Check this PR on Ubuntu22.04LTS server, getting the same results ✅
Contributor
|
PR udpate:
Note that changes only work when you stop then start the gateway instance again. Still LGTM |
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Fixes #148
Tips for QA testing:
move-listwhich should have lists in the correct location upon startup