Feat/ Tezos and Plenty #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
nikspz
approved these changes
Aug 15, 2023
Contributor
There was a problem hiding this comment.
Test performed:
-
Cloned and installed PR6475 + gwPR156
-
Created wallet at kukai.app, not able to use passphrase, not going. no private key available
-
Created wallet https://templewallet.com/ and used this private key
-
connected plenty with templewallet key successfully
-
checked balance successfully
-
created amm_arb strategy using plenty succesfully
-
uniswap_ethereum_arbitrum
- connected wallet successfully, order execution is okay
-
dYdX: connected wallet successfully
-
Dexalot: connected wallet successfully
- Still ongoing issues reproduced on development branch (not related to the PR)
- #184
-
Pancakeswap
- connected wallet successfully, order execution is okay
Note: Performed test for bronze connector, not tested order execution since no testnet available. Checked gold/silver connectors not affected by the PR
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Contributor
|
Hi @OjusWiZard, can you also add the docs for the Tezos chain and Plenty to our docs site - https://github.com/hummingbot/hummingbot-site |
Contributor
Author
|
Heyy @david-hummingbot, I've added the PR here. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Adds Tezos Chain and Plenty connector into the gateway.
Tests performed by the developer:
Added various unit tests for all the functions.
Tested Plenty in Hummingbot (
amm_arbbetween Binance and Plenty).Tips for QA testing:
You will need to run the HummingBot app from the branch of PR #6475 on the HummingBot repo.
Then add a non-empty Tezos wallet using it.
Then create some strategy including Plenty Dex connector on it.
Then start the bot.