这是indexloc提供的服务，不要输入任何密码
Skip to content

(feat) copy token list to conf folder #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

(feat) copy token list to conf folder #146

wants to merge 5 commits into from

Conversation

@cardosofede
Copy link
Contributor

@cardosofede cardosofede commented Jul 5, 2023

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
The token-list used by the connectors changed the location to conf/lists. The user needs to copy and paste the files to get started with the gateway.
This PR solves that issue by copying the files when doing the setup

Tests performed by the developer:

  • Run gateway-setup.sh and check that the files are there.
  • Build the docker image and start the container and check that the files where there too.

Tips for QA testing:

@cardosofede cardosofede requested a review from fengtality July 5, 2023 11:05
@rapcmia rapcmia self-requested a review July 5, 2023 11:57
@fengtality fengtality mentioned this pull request Jul 5, 2023
Closed
@rapcmia
Copy link
Contributor

rapcmia commented Jul 6, 2023 •
edited
Loading

PR update:

  • Test latest commit 243531cfd1
  • Ran test on local mbp (m1)
  • Setup source build for latest client development and this PR
  • Successfully connected gateway ✅

  1. Run gateway-setup.sh and check that the files are there.

    • Confirmed lists folder copied from src/templates to conf when using gateway-setup.sh ✅
      image
      image

  2. Build the docker image and start the container and check that the files where there too.

    • Successfully built docker image for both client and this PR.
    • Tried to setup a docker compose file below using the docker image built using this PR, no avail
      image
      • Tried with adding conf/list on the compose file and still the same result
        image

@cardosofede cardosofede closed this Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fengtality fengtality Awaiting requested review from fengtality

@rapcmia rapcmia Awaiting requested review from rapcmia

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cardosofede @rapcmia @nikspz