这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@fengtality
Copy link
Contributor

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

Tips for QA

  • Setup HB using Hummingbot Gateway Compose with a Gateway image built using this repo
  • Connect to a DEX on Polygon, Avalanche, and BSC => should be able to add wallet successfully
  • Run `gateway connector-tokens [dex-network] [USDC] => balance command should show USDC balance

@fengtality fengtality changed the base branch from main to development June 14, 2023 00:15
@nikspz nikspz self-requested a review June 14, 2023 05:48
Copy link
Contributor

@nikspz nikspz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Test performed:
    • built gateway docker image using this PR (docker build -t hummingbot/gateway:development -f Dockerfile .)
    • Setup HB Client using Hummingbot Gateway Compose with a Gateway image
      • docker compose up -d
      • reviewed hummingbot and gateway pulled/started
      • Set permissions with sudo chmod -R a+rw ./hummingbot_files ./gateway_files
      • docker cp hummingbot:/home/hummingbot/scripts-copy/. ./hummingbot_files/scripts/ then reviewed scripts folder created/ files copied
      • docker cp gateway:/home/gateway/src/templates/lists/. ./gateway_files/conf/lists/ then reviewed gateway lists folder created/ files copied****
      • docker attach hummingbot
      • gateway generate-certs
      • exit Hummingbot then docker compose down
      • Modified YAML file
        • Uncomment out: environment: lines
      • docker compose up -d
      • docker attach hummingbot and docker attach gateway
      • Reviewed gateway is ONLINE
    • connected uniswap, quickswap Polygon mainnet, pangolin Avalanche mainnet, pancakeswap BSC mainnet successfully
    • Ran `gateway connector-tokens [dex-network] [USDC]
    • Reviewed balance command shows USDC and other added tokens balance
      image
      image
      image
      image

@nikspz nikspz merged commit 76660cc into development Jun 14, 2023
@nikspz nikspz deleted the feat/move-all-lists branch June 14, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants