feat/ upgrade traderjoe #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
nikspz
approved these changes
Jun 14, 2023
Contributor
There was a problem hiding this comment.
Tests performed:
- Cloned and install feature branch and Client on development
- Set up gateway and reviewed its ONLINE
- successfully connected traderjoe
- review client shows correct balance
- created/started amm_Arb strategy using traderjoe avalanche
- Review client shows profitability rates
- Set low profitability and reviewed order execution successful
- Tests Curl: allowances/price/trade etc. return expected responses
david-hummingbot
approved these changes
Jun 14, 2023
Contributor
david-hummingbot
left a comment
There was a problem hiding this comment.
Docker Ubuntu 20.04 (amd64)
- build docker image locally successful
- run client and connect traderjoe ok
- balance command works
- run amm_arb strategy ok
- run curl tests ok
fengtality
requested changes
Jun 14, 2023
Contributor
fengtality
left a comment
There was a problem hiding this comment.
See question about MAX_HOPS
| import { createPublicClient, http } from 'viem'; | ||
| import { avalanche, avalancheFuji } from 'viem/chains'; | ||
|
|
||
| const MAX_HOPS = 2; |
Contributor
There was a problem hiding this comment.
would users need to modify this parameter? if so, I think it should be a param in traderjoe.yml
Collaborator
Author
There was a problem hiding this comment.
It's not a parameter regular users should modify in this case. Changing that value without adding more path tokens would have no effect on the final route. It would be a different case if there is an auto/smart router.
fengtality
approved these changes
Jun 16, 2023
This was referenced Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
This pr upgrade TraderJoe to use sdk V2.
Tests performed by the developer:
Tips for QA testing: