这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@vic-en
Copy link
Collaborator

@vic-en vic-en commented May 31, 2023

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
Add EUROC to token list

Tests performed by the developer:

Tips for QA testing:

  • Token balance for EUROC token can be retrieved on Avalanche main net

@vic-en vic-en changed the title addd EUROC token to token list Feat / add EUROC token to token list May 31, 2023
@rapcmia rapcmia requested review from cardosofede, nikspz and rapcmia June 1, 2023 01:56
@rapcmia
Copy link
Contributor

rapcmia commented Jun 1, 2023

Hi @vic-en good day
Would it be possible to rename this from avanlanche to avalanche too? Thank you
image

Copy link
Contributor

@nikspz nikspz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test performed:

  • Review EUROC token added
  • successfully added EUROC to connector-tokens for traderjoe avalanche
  • balance shows correct amount of EUROC
  • gateway approve-tokens traderjoe_avalanche_avalanche EUROC - not going, requested for manual approval
  • Approved with Curl command:

image
https://snowtrace.io/tx/0x92e8764a0f487421b43d6dba7c3439cf261b2e76aabdc1390c58b995d647cf79

NOTES for new campaign:

  1. Current client respond EUROC-AVAX not active market on traderjoe:
    image

  2. EUROC-USDC - Price query failed (no prices showed in status)
    image

  3. EUROC looks like currently not listed on our rate oracle sources (except coingecko which is unusable)
    image

Copy link
Contributor

@cardosofede cardosofede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants