这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@vic-en
Copy link
Collaborator

@vic-en vic-en commented Mar 17, 2023

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
This pr ensures that Injective spot mainnet and testnet is stable.

Tests performed by the developer:

  • Curl tests on clob endpoints

Tips for QA testing:

  • Perform curl tests on clob endpoints for both mainnet and testate

@rapcmia
Copy link
Contributor

rapcmia commented Mar 17, 2023

We are not able to submit orders using Injective mainnet error Injective.getInstance received an unexpected network: null.

Curl test using [POST]/clob/orders
image

Client

2023-03-17 20:06:19,016 - 10120 - hummingbot.connector.gateway.clob_spot.gateway_clob_spot.GatewayCLOBSPOT - NETWORK - Error submitting buy LIMIT_MAKER order to Injective_injective_mainnet for 0.001000000000000000 INJ-USDT 4.366.
Traceback (most recent call last):
  File "/home/rapcmia/github/hummingbot/dev/hummingbot/connector/exchange_py_base.py", line 484, in _create_order
    exchange_order_id = await self._place_order_and_process_update(order=order, **kwargs,)
  File "/home/rapcmia/github/hummingbot/dev/hummingbot/connector/gateway/clob_spot/gateway_clob_spot.py", line 582, in _place_order_and_process_update
    exchange_order_id, misc_order_updates = await self._api_data_source.place_order(order=order, **kwargs)
  File "/home/rapcmia/github/hummingbot/dev/hummingbot/connector/gateway/clob_spot/data_sources/injective/injective_api_data_source.py", line 181, in place_order
    order_result: Dict[str, Any] = await self._get_gateway_instance().clob_place_order(
  File "/home/rapcmia/github/hummingbot/dev/hummingbot/core/gateway/gateway_http_client.py", line 1203, in clob_place_order
    return await self.api_request("post", "clob/orders", request_payload)
  File "/home/rapcmia/github/hummingbot/dev/hummingbot/core/gateway/gateway_http_client.py", line 218, in api_request
    raise e
  File "/home/rapcmia/github/hummingbot/dev/hummingbot/core/gateway/gateway_http_client.py", line 206, in api_request
    raise ValueError(f"Error on {method.upper()} {url} Error: {parsed_response}")
ValueError: Error on POST https://localhost:15888/clob/orders Error: {'message': 'Unknown error.', 'httpErrorCode': 503, 'errorCode': 1099, 'stack': 'Error: Injective.getInstance received an unexpected network: null.\n    at Function.getInstance

Gateway

2023-03-18 01:26:19 | error | 	Injective.getInstance received an unexpected network: null. | Error: Injective.getInstance received an unexpected network: null.
    at Function.getInstance (/home/rapcmia/github/gateway/67/dist/src/chains/injective/injective.js:76:23)
    at new MsgBroadcasterLocal (/home/rapcmia/github/gateway/67/dist/src/chains/injective/injective.message.js:29:45)
    at Function.getInstance (/home/rapcmia/github/gateway/67/dist/src/chains/injective/injective.message.js:48:61)
    at Injective.broadcaster (/home/rapcmia/github/gateway/67/dist/src/chains/injective/injective.js:159:56)
    at InjectiveCLOB.<anonymous> (/home/rapcmia/github/gateway/67/dist/src/connectors/injective/injective.js:136:50)
    at Generator.next (<anonymous>)
    at fulfilled (/home/rapcmia/github/gateway/67/dist/src/connectors/injective/injective.js:5:58)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
chrome_3ChsThyWBh.mp4

Issues reported not happen on development branch when crosschecked

Steps to reproduce

  • Setup development client and this gatewayPR
  • Connect injective wallet successful
  • Setup simple PMM for injective protocol

67.zip

fengtality
fengtality previously approved these changes Mar 19, 2023
@rapcmia
Copy link
Contributor

rapcmia commented Mar 20, 2023

Not able to test again due to #70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants