这是indexloc提供的服务，不要输入任何密码
Skip to content

Feat/add sushiswap networks #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 15, 2023
Merged

Feat/add sushiswap networks #60

merged 8 commits into from
Mar 15, 2023

Conversation

@fengtality
Copy link
Contributor

@fengtality fengtality commented Mar 15, 2023

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

  • Adds support for Sushiswap on the Avalanche, Arbitrum and Harmony chains

@fengtality fengtality requested a review from rapcmia March 15, 2023 03:43
@nikspz
Copy link
Contributor

nikspz commented Mar 15, 2023 •
edited
Loading

Test performed:

  • Cloned and installed gwPR60
  • Checked gateway list added avalanche, harmony and ethereum(arbitrum) to sushiswap
  • Connected sushiswap_avalanche_avalanche
  • connected sushiswap_ethereum_arbitrum_one
    • balance: ok
    • created amm_arb using sushiswap_ethereum_arbitrum_one: ok
    • WETH,USDC could be approved using approve-tokens command.
    • Approved BentoBox, WETH,USDC manually on the sushiswap
    • Started amm_arb strategy using arbitrum
  • connected sushiswap_harmony_mainnet
    • balance: ok
    • created amm_arb using sushiswap_harmony_mainnet: ok
    • WONE, USDC not approved using approve-tokens command. (Error on POST evm/approve)
    • Approved WONE,USDC manually on the sushiswap
    • Was able to start amm_arb strategy using harmony

nikspz
nikspz previously approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@nikspz nikspz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Tests performed:

  • Cloned and installed gwPR60
  • Connected sushiswap_avalanche_avalanche
    • balance: ok
    • created amm_arb using sushiswap_avalanche_avalanche: ok
    • Approved WAVAX,USDT on the sushiswap
    • Was able to start amm_arb strategy using sushiswap_avalanche_avalanche
  • connected sushiswap_ethereum_arbitrum_one
    • balance: ok
    • created amm_arb using sushiswap_ethereum_arbitrum_one: ok
    • Approved WETH,USDC on the sushiswap
    • Was able to start amm_arb strategy using sushiswap_ethereum_arbitrum_one
  • connected sushiswap_harmony_mainnet
    • balance: ok
    • created amm_arb using sushiswap_harmony_mainnet: ok
    • Approved WONE,USDC on the sushiswap
    • Was able to start amm_arb strategy using sushiswap_harmony_mainnet

@fengtality fengtality merged commit 2daff0d into development Mar 15, 2023
@fengtality fengtality deleted the feat/add-sushiswap-networks branch March 15, 2023 19:14
@rapcmia rapcmia mentioned this pull request Mar 28, 2023
Merged
2 tasks
This was referenced Mar 29, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikspz nikspz nikspz left review comments

@rapcmia rapcmia Awaiting requested review from rapcmia

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fengtality @nikspz