Updated test/pools/pools.routes.test.ts to work with the enhanced Pool interface that now includes baseTokenAddress, quoteTokenAddress, and feePct fields.

Changes:
- Added required fields (baseTokenAddress, quoteTokenAddress, feePct) to all mock Pool objects
- Updated POST /pools test expectation to use expect.objectContaining() since the route now fetches and adds pool info automatically
- Removed outdated planning documents (POOL_MIGRATION_OUTSTANDING.md, POOL_STORAGE_REFACTOR_PLAN.md)

All 13 tests now passing.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

- Replace per-network scanAPIKey with single etherscanAPIKey in ethereum.yml
- Migrate from V1 to V2 API endpoint (https://api.etherscan.io/v2/api)
- Add automatic chain support detection (Ethereum, Polygon, BSC verified)
- Implement chainId-based service initialization instead of network names
- Add comprehensive test suite with 17 tests covering API calls and error handling
- Update gas configuration guide with Etherscan V2 integration details
- Gracefully fall back to RPC for unsupported chains (Base, Arbitrum, Optimism)

This change provides more accurate EIP-1559 gas estimates using Etherscan's
gastracker module across all supported chains with a single API key.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

- Update Base/Optimism/Arbitrum examples to use 0.01 GWEI (from 0.1)
- Update BSC example to use 3.0 GWEI for legacy transactions
- Update all log examples to reflect actual configured values
- Clarify network-specific examples in configuration strategies
- Update API response examples with correct gas values
- Add notes explaining minGasPrice floor behavior for each network type

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

- Change Polygon minGasPrice from 30 to 10 GWEI
- Update maxFeePerGas and maxPriorityFeePerGas to 10 GWEI
- Update nodeURL to rpc.ankr.com/polygon
- Update nativeCurrencySymbol from MATIC to POL

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Remove legacy pool lookup code from CLMM open-position routes to align
with the existing schema requirement that poolAddress is mandatory.

Changes:
- Remove unused baseTokenSymbol and quoteTokenSymbol parameters from
  Raydium CLMM openPosition function
- Remove dead pool lookup code (12 lines) from Raydium implementation
- Remove misleading baseToken/quoteToken examples from Uniswap schema
- Update Uniswap poolAddress example to show real address

This is a non-breaking change since the schema already requires
poolAddress. All existing tests pass.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

…itions

Update minGasPrice values to reflect current network requirements:
- BSC: 0.1 → 3 GWEI
- Polygon: 0.1 → 10 GWEI (align with conf template)

These values match the actual network conditions and align with the
values already documented in the configuration templates.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Move getPool querystring schema to src/pools/schemas.ts and use
Type.String with enum property instead of inline definition to enable
proper dropdown selection in Swagger UI.

Changes:
- Add GetPoolRequestSchema to src/pools/schemas.ts
- Use enum: ['amm', 'clmm'] for type field to create dropdown
- Import and use schema in getPool route

This allows users to select pool type from a dropdown in Swagger UI
instead of having the value hardcoded.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Update GetPoolRequestSchema to default to 'mainnet-beta' instead of
'mainnet' to align with Solana connector defaults (raydium, meteora).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

- Explicitly override network default to 'mainnet-beta' in querystring
- Change tradingPair examples to show SOL-USDC first instead of ETH-USDC
- Ensure Swagger UI displays correct defaults for Solana connectors

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

…T /pools

Change baseTokenAddress and quoteTokenAddress from optional to required
fields in the add pool endpoint to ensure data consistency.

Changes:
- Remove Type.Optional wrapper from baseTokenAddress and quoteTokenAddress
  in PoolAddRequestSchema
- Update PoolAddRequest interface to make these fields required (not optional)
- Simplify addPool route logic since token addresses are now always provided
- Only fetch pool-info if feePct is missing

This ensures all pools have validated token addresses and prevents
inconsistencies in pool data.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Add metadata-based duplicate detection to prevent multiple pools with
the same characteristics (type, network, feePct, token addresses) but
different addresses.

Changes:
- Add getPoolByMetadata method to PoolService to find pools by metadata
  instead of just address
- Update addPool route to check for existing pools with matching metadata
- If pool with same metadata exists but different address: remove old
  pool and add new one (replacement)
- If pool with same metadata and address exists: update it
- If no matching metadata: add as new pool

This ensures the pool database doesn't contain duplicate entries with
identical trading characteristics but different addresses.

Example: Prevents having two JUP-USDC CLMM 0.01% pools on mainnet-beta
with different addresses.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Change pool duplicate detection to match only on type, network, and
token addresses (baseTokenAddress, quoteTokenAddress), ignoring feePct.
When a new pool is added with the same token pair but different fee
tier, it replaces the existing pool.

Changes:
- Remove feePct parameter from getPoolByMetadata method
- Match pools based only on type, network, and token pair
- When same token pair with different fee tier is added: replace old pool
- When same token pair with same address is added: update fee tier
- Updated success messages to show old and new fee tiers on replacement

This ensures only one pool per token pair (per type/network) exists,
preventing duplicate entries with different fee tiers.

Example: Adding JUP-USDC 0.25% will replace existing JUP-USDC 0.01%

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Update pool routes tests to match new required fields (baseTokenAddress,
quoteTokenAddress) and new pool duplicate detection logic.

Changes:
- Add getPoolByMetadata and updatePool to mock PoolService
- Update POST /pools test payloads to include required baseTokenAddress
  and quoteTokenAddress fields
- Add feePct to test payloads
- Update "duplicate pool" test to "update existing pool" test since
  duplicate addresses now trigger updates instead of errors
- Add proper mocks for getPoolByMetadata and getPoolByAddress

All 13 pool routes tests now pass.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Changes:
1. Created comprehensive Infura regression test (test/chains/ethereum/infura-config-regression.test.ts)
   - Tests InfuraService initialization when rpcProvider=infura
   - Verifies provider is using Infura endpoints (not nodeURL)
   - Validates API key configuration
   - Tests health checks and gas price estimation
   - Properly skips when Infura is not configured

2. Improved Infura logging messages for clarity:
   - Separate warning and info messages instead of combined "fallback" message
   - Explicitly show nodeURL when falling back to standard RPC
   - Clearer Etherscan API fallback message

3. Made messages consistent with Helius improvements:
   - No confusing "fallback" wording when using configured provider
   - Clear indication of what's being used and what's not

This matches the pattern established in the Helius integration and ensures
both RPC provider abstractions have consistent testing and logging.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Changes:
- Fix parsing error when amount is empty string ""
- Properly check for empty/whitespace strings before parsing
- Use MaxUint256 for undefined, null, empty, or whitespace amounts
- Add logging to show when max approval is being used

This fixes the "fractional component exceeds decimals" error that occurred
when users sent an empty string for amount (which should trigger max approval).

The previous code used `amount ? parseUnits(...) : MaxUint256` but empty string
is falsy in JavaScript, so it should have worked. However, the schema might be
coercing it or the check wasn't strict enough. Now we explicitly check for
empty/whitespace strings.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Changes:
- Move HeliusService initialization inside the if block (API key present)
- Don't create HeliusService when no API key is configured
- Improve logging messages to match feat/pancakeswap-sol branch

This fixes the helius-config-regression.test.ts failures where:
- solana.config.useHeliusRestRPC was undefined
- solana.config.heliusAPIKey was undefined
- heliusService was undefined

The issue was that HeliusService was being created even when there was
no API key, but this.config wasn't being updated with the merged config
in that case, causing test failures.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

…unning

Changes:
- Check both GATEWAY_TEST_MODE=dev AND rpcProvider=helius before running
- Import getSolanaChainConfig to verify actual rpcProvider setting
- Skip tests when Helius is not configured (rpcProvider: url)
- Add documentation about test requirements

This fixes CI/CD failures where:
- GATEWAY_TEST_MODE=dev is set ✅
- But rpcProvider: url in templates (not helius) ❌
- Tests ran and failed instead of skipping

Now the test properly skips in CI/CD environments where Helius
is not configured, matching the Infura test pattern.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Changes:
- Test now configures Helius before testing (sets rpcProvider: helius)
- Backs up and restores original configs in beforeAll/afterAll
- Forces singleton reload to pick up test configuration
- No longer skips based on existing config - actively tests the fix

This ensures the regression test actually tests the fix in all environments,
including CI/CD where Helius may not be pre-configured.

The test now:
1. Writes test configs for Helius
2. Clears Solana singleton
3. Creates new instance with Helius enabled
4. Verifies config was properly merged
5. Restores original configs

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Changes:
- Clear ConfigManagerV2 singleton before creating Solana instance
- Fix property name: useWebSocketRPC (not useWebSocket) to match schema
- Import ConfigManagerV2 to access singleton

This was the missing piece - writing config files wasn't enough because
ConfigManagerV2 caches configs. Now the test:
1. Writes test configs
2. Clears ConfigManagerV2 singleton (forces config reload)
3. Clears Solana singleton
4. Creates new Solana instance with fresh configs
5. Verifies the fix worked

The test now properly validates that the merged Helius config is applied
to this.config in all environments including CI/CD.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>