这是indexloc提供的服务,不要输入任何密码
Skip to content

Feat/log config #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

WuonParticle
Copy link
Contributor

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

  • Make fastify logs useful by eliminating ping logs (turn on fastify logs by modify conf/server.yml
  • Some linting changes from extending line width got included.
  • Added logFilenameFormat config value as log files were not creating symlinks for stach traces without the .log extension

Tests performed by the developer:
pnpm clean && pnpm install && pnpm build && pnpm test && pnpm start --dev

Tips for QA testing:

  1. checkout development (e.g. not this branch)
  2. Change conf/server/yml : fastifyLogs to true
  3. run pnpm build
    2 run pnpm start,
  4. Start hbot
  5. See ping logs for / are in gateway console
  6. kill gateway & hbot
  7. checkout this branch
  8. run pnpm build
    2 run pnpm start,
  9. Start hbot,
  10. see ping logs are no longer flooding the console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant