-
-
Notifications
You must be signed in to change notification settings - Fork 218
sync / Gateway staging -> master for Hummingbot version 2.7.0 #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat / update development 2.7.0
- Changed ConfigTemplatesDir from ConfigDir to 'dist/src/templates/' - Fixes ENOENT error when starting Docker container with empty volumes - Ensures template files can be properly copied from build directory to conf directory 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…r messages - Register @fastify/sensible plugin to enable httpErrors functionality - Add LP token address to insufficient allowance error message for clarity - Fix error type annotation in catch block The remove-liquidity endpoint now properly returns BadRequest errors with helpful messages that include the LP token address (pool address) that needs approval. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Remove NFT approval checks from removeLiquidity and collectFees endpoints - Delete unused approveNFT endpoint and route registration - Uniswap V3 Position Manager doesn't require approval for positions it minted - Fix WETH allowance checks to treat WETH like any other ERC20 token - Update positionsOwned to return standard PositionInfo objects - Enhance ethereum/allowances to accept token addresses directly - Add LP token address to error messages for clarity - Use Uniswap V3 SDK Position class for accurate calculations - Add firstWalletAddress logic to CLMM endpoints - Move shared functions and ABIs to appropriate locations 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Fix / Uniswap connector error handling, WETH allowances, and NFT approval checks
- Fixed BUY order calculations to properly handle EXACT_OUTPUT trades - Added balance checks before swap execution with clear error messages - Set fixed gas limit of 300,000 for all Uniswap V3 swaps - Removed minimum gas price constraint to use market rates - Allow all Ethereum networks configured in ethereum.yml - Dynamically fetch networks from configuration instead of hardcoded lists - Added comprehensive tests for BUY/SELL operations and gas parameters 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Removed EXACT_INPUT workaround for BUY orders as AlphaRouter now works correctly - Removed BUY order sanity check as it's no longer needed - Removed test README.md file 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Removed calldata decoding and validation logic - Removed amount validation checks for BUY orders - Trust AlphaRouter's output without additional verification 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Fix / Uniswap router BUY orders and improve gas handling
… an example address
Reference bigint-buffer to avoid warning about falling back to js int. Fixes #44
Previously, estimateAmountIn was incorrectly returning the base token amount for BUY orders instead of the quote token amount needed. This fix ensures: - BUY orders: estimateAmountIn = quote token amount needed - SELL orders: estimateAmountIn = base token amount to sell - Balance changes correctly reflect token movements 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…nParticle-feat/startup_noise
Wuon particle feat/startup noise
auto linting
Add import alias support
fix: correct Jupiter quote-swap estimateAmountIn for BUY orders
- Introduced static variable `_walletAddressExample` to store example wallet addresses. - Updated `getWalletAddressExample` method to return stored example or default address if none found.
…fic import-resolver version, exclude dist and coverage dirs
fix nested import/resolver change from llm
Solana example address noise followup
…ment import aliases follow up
add json auto linting.
- Updated CLAUDE.md with passphrase requirements, supported networks/DEXs, and environment variables - Restructured README.md with comprehensive API endpoints, improved architecture section, and development guide - Enhanced test/README.md with detailed test structure, mock file conventions, and troubleshooting guide - Removed deprecated CLI documentation as requested 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Created AGENTS.md as the main source of agent instructions - Changed agent-specific language to be generic (AI coding assistants) - Created symlinks CLAUDE.md and GEMINI.md pointing to AGENTS.md - Ensures compatibility with multiple AI coding assistants (Claude, Gemini, Cursor, etc.) - Single source of truth for maintenance 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
docs: update documentation and create generic AI agent instructions
sync / Gateway development -> staging 2.7.0
fix / Update staging 2.7.0
rapcmia
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Tests performed by the developer:
Tips for QA testing: