Feat/cardano #484
Open
Feat/cardano #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r sundaeswap also written test cases for cardano chain and minswap and sundaeswap
|
Note that Gateway is in the middle of a big refactor outlined in: #467. v2.8 is slated for release in August. There are more changes coming wrt to the Hummingbot-Gateway interface, esp for sending and confirming transactions. As this interface needs to be designed to fit Ethereum and Solana chains and wallets, we will defer reviewing and merging PRs for non EVM and non SVM chain architectures until a later date, yet to be announced. In the meantime, I encourage you to keep your fork up to date with the changes in v2.8 and subsequent releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Adding a new chain for the Cardano Blockchain along with Minswap & Sundaeswap dex.
Allow users to trade and add/remove liquidity on AMM on these Cardano Dexs.
Tests performed by the developer:
Manual testing as well as Unit testing.
path for test cases: test/chains/cardano
path for AMM tests Minswap: test/connectors/minswap
path for AMM tests Sundaeswap: test/connectors/sundaeswap
Tips for QA testing:
Can execute swap, add and remove liquidity in both Cardano Dex.