Uniswap router revert #449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the swapERC20CallParameters error by ensuring AlphaRouter consistently uses SWAP_ROUTER_02 type, which produces compatible calldata for the SwapRouter02 contract. Added detailed logging for debugging. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
* Fixed the SwapRouter.swapERC20CallParameters error by completely removing Universal Router type * Added direct import of getUniswapV3SmartOrderRouterAddress instead of using getSpender * EXPLICITLY set SwapType.SWAP_ROUTER_02 in all routes * Improved error logging for debugging purposes 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This adds implementations for methods that were being called without implementation, fixing type errors: - getTokenBySymbol: For resolving tokens by symbol in the Uniswap class - getV3Pool: For accessing V3 pools by token pairs and optional fee tier/pool ID - findDefaultPool: For finding pool addresses based on configuration 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Use simpler AlphaRouter implementation similar to v2.2.0 - Fix token resolution using Ethereum class - Remove unused Universal Router dependencies - Update package.json to remove unneeded packages - Fix type errors in execute-swap.ts and quote-swap.ts
…etInstance and cleaner architecture
…rove route caching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Tests performed by the developer:
Tips for QA testing: