(feat) source-maps #442
Merged
(feat) source-maps #442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate source-maps for compiled Typescript and enable use of source-maps in NODE_OPTIONS. This will make stacktraces have correct line numbers for Typescript source.
fengtality
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate source-maps for compiled Typescript and enable use of source-maps in NODE_OPTIONS. This will make stacktraces have correct line numbers for Typescript source.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
This change builds source-maps with the Typescript compiler and enables source-maps in the node runtime
Tests performed by the developer:
Checked that source-maps were run and generated by tsc. Ran server with pnpm start and triggered an error that generated a stacktrace, which now shows line numbers in the Typescript source.
Tips for QA testing:
Build and run server. Trigger some sort of exception to verify stacktrace.