这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@humitos
Copy link
Owner

@humitos humitos commented Aug 14, 2018

The major change in this PR is that it removes completely the ability to add a warning banner statically using sphinx internals. Ref #13

There is an example of a banner with flask-style at https://sphinx-version-warning-example.readthedocs.io/en/flask-like-warning/ that uses this PR to generates it.

Also:

  • makes the extension visible under versionwarning.extension, instead of under versionwarning as it was before. It avoid possible circular imports.
  • removes unnecessary files.
  • all the config options are included/considered in the json file.

ToDo:

  • update documentation
  • manual QA
  • write tests to check the generated .json file

Closes #13

@humitos humitos mentioned this pull request Aug 14, 2018
@humitos humitos force-pushed the only-dynamic-banner branch 2 times, most recently from 71c0392 to 40bab04 Compare October 21, 2018 19:39
@humitos humitos merged commit 707455b into master Oct 21, 2018
@humitos humitos mentioned this pull request Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants