Fix empty initial results on streaming queries #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…results. Also you can now only poll_until_done() on static queries, as a live query will always yield the most modern segment of a query result, so it doesn't make sense for that to have this feature
…er this feature is needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changes Have Been Made?
Fixed a bug, where poll_until_done would return an empty result if the query job hadn't started up. Will now wait for an initial batch of data to be returned.
Fixed a bug, where only the first segment of results from a static query job will be returned. Now poll_until_done will return all segments.
Removed the poll_until_done method from live queries, as this doesn't make sense for live queries.
Why Have the Changes Been Made?
The changes have been introduced so users can be sure to get all their result data from their static queries.
How Do These Changes Impact the User?
Live queries using the poll_until_done method will have to be redone in the calling code.