Add functionality for assigning roles to groups #984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4cbbeaa to
b2b945a
Compare
b2b945a to
61f67a1
Compare
arbaadrian
approved these changes
May 21, 2025
bsocaciu
reviewed
May 21, 2025
…text" container already specifies the same labels
jswoods
approved these changes
May 22, 2025
Before this change, we relied on the next "regular" reconcile to come around and remove the finalizer. With this new change, it means the finalizer marker gets removed much faster and that means object deletions finish much quicker than before.
…me" on HumioGroup CRD
This was referenced May 27, 2025
triceras
pushed a commit
that referenced
this pull request
Jul 2, 2025
* Add functionality for assigning roles to groups * Address review comment * Address review comment * Address review comment * Address review comment * Remove unnecessary ginkgo labels for some "It" containers as the "Context" container already specifies the same labels * Requeue immediately when finalizer runs successfully Before this change, we relied on the next "regular" reconcile to come around and remove the finalizer. With this new change, it means the finalizer marker gets removed much faster and that means object deletions finish much quicker than before. * Fix samples to match the real field names * Fix panic and swap minLength for fields "Name" and "ExternalMappingName" on HumioGroup CRD
triceras
pushed a commit
that referenced
this pull request
Sep 18, 2025
* Add functionality for assigning roles to groups * Address review comment * Address review comment * Address review comment * Address review comment * Remove unnecessary ginkgo labels for some "It" containers as the "Context" container already specifies the same labels * Requeue immediately when finalizer runs successfully Before this change, we relied on the next "regular" reconcile to come around and remove the finalizer. With this new change, it means the finalizer marker gets removed much faster and that means object deletions finish much quicker than before. * Fix samples to match the real field names * Fix panic and swap minLength for fields "Name" and "ExternalMappingName" on HumioGroup CRD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.