Allow user-defined sidecars #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jswoods
approved these changes
Nov 12, 2020
414ac10 to
b8933a8
Compare
added 4 commits
November 13, 2020 11:04
This is a generic approach to be able to add sidecars that can dump debugging insights. Fixes #254
…oller-gen version to fix this.
b8933a8 to
beb2530
Compare
…and updates to CRD's
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also pulled out the container names to a const, which has it's own commit.
Ran into an issue with the generated HumioCluster CRD which seems to cause problems for k8s v1.18+ so I created an issue for that.
Question is now, do we want to move forward with this PR now or should we wait until we can get a version of controller-gen which doesn't suffer from this issue? Alternatively, we could also decide to update our
Makefileso we grab a more recent controller-gen binary than the newest release available. I already tested this by pointing directly to master of controller-gen, and this seems to work just fine.