Add env vars to the spec, merge in defaults #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schofield
approved these changes
Mar 13, 2020
| - name: "KAFKA_SERVERS" | ||
| value: "humio-cp-kafka-0.humio-cp-kafka-headless:9092" | ||
| - name: "SINGLE_USER_PASSWORD" | ||
| value: "temp" # Should this be auto-generated/moved to a secret? |
Contributor
There was a problem hiding this comment.
I like what we do now, i'd move to a secret.
SaaldjorMike
approved these changes
Mar 13, 2020
triceras
pushed a commit
that referenced
this pull request
Mar 12, 2025
Add env vars to the spec, merge in defaults
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7.
Not sure if this is how we should set defaults or not. There is definitely some additional work around this like setting the xss/xms/xmx in HUMIO_JVM_ARGS.