Add support for custom labels to humio service #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @kaspernissen! This looks good to me. The only thing - do you mind squashing the commits? |
Author
|
Thanks @jswoods! Isn't squash merging this to master sufficient using the Github functionality - or do you want me to squash merge locally and force push using rebase (then I'll start googling) ? |
Contributor
|
@kaspernissen tbh, I haven't never used that but I will try it out! Usually on our team we squash first and then just do a plain merge from github :). But sounds like it should achieve the same goal. |
jswoods
approved these changes
Nov 12, 2020
Author
|
Haha, tbh, I have never done it the other way around 🙈 Let me know if you want me to give it a go locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to add custom labels to the humio service created by the humio-operator.
Services like
linkerdmulticluster looks for a specific label to mirror services to multiple clusters.I have added it to the
HumioClusterresource asHumioServiceLabels. It may be a good idea in a future PR to nest these specificServiceconfigurations under a top-levelserviceobject or similar, as you already do with ingress.