More cluster states #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
03925b5 to
9207f63
Compare
Closed
Contributor
|
Guess we could leverage the status endpoint to obtain the version: https://github.com/humio/cli/blob/master/api/status.go#L12 The version is also available using the new health endpoint: https://github.com/humio/cli/blob/master/api/health.go#L31 The first one does not require any special permissions whereas the second one does, so I think we should just use the simpler one which in this case would be the first one. |
SaaldjorMike
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of a hack to get the version. We should instead pull this from the humio api.
Depends on #34 so this diff currently pulls in everything from that as well.