Feature/view actions #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er sucessfully deleteting a repository
danielamkaer
requested changes
Nov 5, 2020
Collaborator
danielamkaer
left a comment
There was a problem hiding this comment.
LGTM. Tested the commands and found no issues.
Co-authored-by: Daniel Amkær Sørensen <danielamkaer@users.noreply.github.com>
Co-authored-by: Daniel Amkær Sørensen <danielamkaer@users.noreply.github.com>
Co-authored-by: Daniel Amkær Sørensen <danielamkaer@users.noreply.github.com>
Contributor
Author
|
Thanks for the quick reaction. I have committed the suggested changes. |
Contributor
Author
|
Thanks. 🚀 Quick question. Would it be possible to get a new release of the CLI? We would need it to complete humio/humio-operator#207 |
Collaborator
|
Sure. Version 0.28.1 released. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR relates to the following issue: humio/humio-operator#207 - CRD for HumioViews
The View API needs additional functions before we can add a CRD for managing views. This is the first PR on that journey.
This is my first open source PR so bear with me
Overview of changes
Added the following operations to Views
Updated the CLI with the new operations as well.
Fixed a bug in Delete repository which returned an error after successfully deleting a repository due to a graphQL query error.