Client api improvements for notifiers and alerts #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed fatal exits from the notifier and alerts code. Since the client api is used by other projects, we should not do `log.Fatal` since it crashes the code which depends on this api. * Changed where we check if the config address is set first before trying to load the config. Otherwise it panics. * Only try to get a notifier's ID when the ID is not set * Updated so we return the error string in the case the humio api calls fail. This is important when a request is rejected for validation reasons (like a missing or invalid field) but the error returned by the humio api is not a json response.
SaaldjorMike
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log.Fatalsince it crashes the code which depends on this api.