fix(ENG-2114): Fix port conflicts for concurrent daemon/WUI instances #582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix IPv6 port detection: Vite binds to ::1 but port checks only tested IPv4 - Separate port ranges to prevent daemon/Vite conflicts across sessions - Pass calculated ports as parameters to avoid recalculation conflicts - Fix bun command syntax in wui-ticket target Daemon ports: ticket_num, 20000-29999, 40000-49999 Vite ports: 10000-19999, 30000-39999, 50000-59999 This ensures multiple instances (make codelayer-dev TICKET=ENG-XXXX) can run concurrently without port conflicts.
Use getDaemonUrl() to properly show the daemon URL when running with environment variables (VITE_HUMANLAYER_DAEMON_URL). Previously showed "Not connected" even when connected via env config.
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 5077fe9 in 1 minute and 40 seconds. Click for details.
- Reviewed
260lines of code in3files - Skipped
0files when reviewing. - Skipped posting
4draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. Makefile:682
- Draft comment:
In the wui-ticket target, the conditionif [ -z "$(PORT)" ] || [ -z "$(VITE_PORT)" ]forces auto-allocation if either variable is missing. This means a user-supplied PORT could be overridden when VITE_PORT is not provided. Consider checking them separately so manual overrides aren’t lost. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50% The comment is technically correct - if a user provides PORT but not VITE_PORT, their PORT value will be ignored and both values will be auto-allocated. However, these are dev/testing targets and the PORT and VITE_PORT are meant to be used together. Having one without the other doesn't make much sense from a usage perspective. The current behavior of requiring both or auto-allocating both is actually safer and more consistent. I could be wrong about the intended usage - maybe there are valid cases where a user wants to specify just one of the ports. The comment does identify a real logical issue in the code. While technically correct, the current behavior is likely intentional for consistency and proper operation of the dev environment. The ports need to work together, so partial manual configuration could lead to issues. The comment should be deleted. While technically accurate, the current behavior is reasonable for a dev/testing target where the ports need to be coordinated.
2. Makefile:686
- Draft comment:
The command change from 'bun tauri dev' to 'bun run tauri dev' looks intentional, but ensure that this is compatible with all target environments and documented accordingly. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. hack/port-utils.sh:29
- Draft comment:
The function first tries to use the ticket number directly as a port. If the extracted ticket number is very low (e.g. below 1024), this might cause permission issues or conflicts. Consider enforcing a minimum port value or always using the higher range. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. humanlayer-wui/src/components/DebugPanel.tsx:72
- Draft comment:
Nice improvement: using getDaemonUrl() to fetch the actual daemon URL instead of relying on a global variable. Ensure that getDaemonUrl handles errors and edge cases gracefully. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_WYAiuvG1rLELTz2o
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
dexhorthy
approved these changes
Sep 18, 2025
…-wuis-concurrently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem(s) was I solving?
This PR fixes critical port allocation bugs that prevented multiple concurrent daemon/WUI instances from running reliably. These bugs were introduced in #573 and discovered when testing multiple
make codelayer-dev TICKET=ENG-XXXXsessions.Issue 1: IPv6 port detection failure
Issue 2: Overlapping port ranges
Issue 3: Port recalculation conflicts
Issue 4: Debug panel visibility
Related to: ENG-2114
What user-facing changes did I ship?
Port Allocation
make codelayer-dev TICKET=ENG-XXXXsessions now work reliably without conflictsDebug Panel
http://localhost:22119) instead of "Not connected"How I implemented it
IPv6-Aware Port Detection (
hack/port-utils.sh)lsofoverncas it correctly detects both IPv4 and IPv6 bindingsSeparated Port Ranges
Port Parameter Passing (
Makefile)codelayer-devcalculates ports once and passes them to sub-targetsdaemon-ticketandwui-ticketaccept PORT and VITE_PORT parametersbun run tauri devcommand syntaxDebug Panel Fix (
humanlayer-wui/src/components/DebugPanel.tsx)getDaemonUrl()to fetch actual daemon URL from all sourcesVITE_HUMANLAYER_DAEMON_URL) properlyHow to verify it
make checkpassesmake testpasses (4 unrelated Python tests failing - not affected by these changes)Manual Testing
Test concurrent instances:
Verify debug panel:
Test port detection:
make test-port-allocation TICKET=ENG-2119 # Should show available port considering both IPv4 and IPv6Description for the changelog
Fixed critical port allocation bugs preventing concurrent daemon/WUI instances: IPv6-aware port detection, separated daemon/Vite port ranges, consistent port assignment via parameters, and corrected debug panel daemon URL display.