feat: add ErrorBoundary protection for TipTap ResponseEditor #522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added ResponseEditorErrorBoundary component to gracefully handle TipTap editor errors and prevent crashes. The error boundary displays a simple error message when the editor encounters an issue. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 5cfdf8b in 1 minute and 19 seconds. Click for details.
- Reviewed
125lines of code in2files - Skipped
0files when reviewing. - Skipped posting
4draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. humanlayer-wui/src/components/internal/SessionDetail/components/ResponseEditorErrorBoundary.tsx:47
- Draft comment:
Missing trailing newline at the end of the file. Consider adding a final newline to adhere to code style conventions. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. humanlayer-wui/src/components/internal/SessionDetail/components/ResponseEditorErrorBoundary.tsx:29
- Draft comment:
Consider adding an ARIA role (e.g. role='alert') on the fallback container for improved accessibility. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
3. humanlayer-wui/src/components/internal/SessionDetail/components/ResponseInput.tsx:183
- Draft comment:
Wrapping ResponseEditor in the error boundary may affect ref forwarding. Verify that tiptapRef is correctly receiving the editor instance, or consider using forwardRef in the error boundary if needed. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
4. humanlayer-wui/src/components/internal/SessionDetail/components/ResponseEditorErrorBoundary.tsx:29
- Draft comment:
Consider adding a retry or reset option in the error fallback UI to allow users to attempt reloading the editor. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_SVPDY5cRnp0GGHsB
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
dexhorthy
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem(s) was I solving?
Fixed two critical UI issues with the ResponseEditor component:
Related issues:
What user-facing changes did I ship?
Error Handling
Send Button Improvements
How I implemented it
Error Boundary Component (
ResponseEditorErrorBoundary.tsx)ResponseInput Integration
Send Button Animation Fix
invisibleclass (preserves space) to conditional renderingtransition-all duration-200for smooth width animations⌘+EnterorCtrl+Enter) only renders when button is enabledHow to verify it
make check testpassesManual Testing
Test Error Boundary:
Test Send Button Animation:
General Regression Testing:
Description for the changelog
Added error boundary protection for TipTap ResponseEditor to prevent crashes and improved Send button UX with smooth animations and proper space management when disabled.