Fix draft table to show user message preview when title is blank #768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draft sessions store prompts in editorState field as TipTap JSON rather than in the query field. Added utility to extract plaintext from TipTap editor state and updated SessionTable to use this extracted text as a fallback when displaying drafts without titles or summaries. This ensures users can see their draft prompts in the table view even when they haven't set a custom title.
Contributor
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to fad74fa in 2 minutes and 0 seconds. Click for details.
- Reviewed
86lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. humanlayer-wui/src/utils/formatting.ts:169
- Draft comment:
Good defensive JSON parsing in extractTextFromEditorState. Optionally log the parse error for debugging, and consider adding delimiters (e.g., spaces) when joining text nodes to avoid run-together words. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 30% vs. threshold = 50% The error logging suggestion is not critical - if parsing fails, returning empty string is a reasonable fallback. The delimiter suggestion is more interesting since joining without spaces could cause text to run together incorrectly. However, we don't have enough context about the TipTap editor structure to know if this is actually a problem - paragraphs might already have spaces, or running text together might be intended. I might be underestimating the importance of error logging for debugging. Also, even without full context, preventing run-together words seems like a reasonable suggestion. While valid points, neither suggestion shows clear evidence of being necessary. The code works as written, and we'd need more context about TipTap's structure to know if word spacing is actually an issue. The suggestions are reasonable but speculative without more context. Following our principle of only keeping comments with strong evidence of being necessary, we should remove this comment.
Workflow ID: wflow_5iROzFZBeqdbhRng
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
dexhorthy
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem(s) was I solving?
Fixed ENG-2293 - Draft sessions in the table view showed empty cells when no title was set, making it impossible for users to identify their drafts.
The root cause was that draft sessions store prompt text in the
editorStatefield as TipTap JSON (rich editor format) rather than in thequeryfield. Thequeryfield only gets populated when a draft is launched, meaning unlaunch drafts always had an emptyqueryfield and would display as blank in the table.What user-facing changes did I ship?
The drafts table now shows content with this priority:
How I implemented it
Added text extraction utility (
humanlayer-wui/src/utils/formatting.ts)extractTextFromEditorState()function that parses TipTap JSON and extracts plaintextUpdated SessionTable display logic (
humanlayer-wui/src/components/internal/SessionTable.tsx)extractTextFromEditorStateto the import listThe implementation follows existing patterns in the codebase (similar to
getSessionNotificationText) and requires no backend changes since theeditorStatefield is already returned by the ListSessions API.How to verify it
Automated Testing
make -C humanlayer-wui checkmake -C humanlayer-wui lintmake -C humanlayer-wui testManual Testing
Test draft with prompt but no title:
Test existing behavior is preserved:
Test truncation:
Description for the changelog
Fixed draft sessions showing as blank in the drafts table when no title was set. The table now displays a preview of the draft's prompt text, making it easy to identify drafts at a glance.