fix: max thinking tokens #758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to ad41c7d in 1 minute and 25 seconds. Click for details.
- Reviewed
16lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .claude/settings.json:10
- Draft comment:
Consider verifying that MAX_THINKING_TOKENS is intended as a string. If the consuming code expects a numeric value, it might be better to set it as a number (without quotes). - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% This is a classic case of premature optimization/speculation. JSON technically allows both string and numeric types, and without seeing the code that consumes this value, we can't know if it matters. The comment is asking for verification rather than pointing out a clear problem. It's the kind of comment that creates unnecessary back-and-forth. Maybe there's a standard in this codebase for using numeric values in JSON configs when possible? Maybe the reviewer has seen issues with string/number type mismatches before? Even if there is such a standard, the comment should state that directly rather than asking for verification. And without evidence that this actually causes problems, it's not worth changing. Delete this comment. It's speculative, asks for verification, and doesn't point out a clear problem that needs fixing.
2. .claude/settings.json:13
- Draft comment:
Add a newline at the end of the file to adhere to best practices. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% While having a newline at end of file is a common best practice, this is a minor formatting issue that: 1) Would likely be caught by linters/formatters if it was important to the project 2) Doesn't affect the functionality of the JSON 3) Is more of an informational comment than a required code change 4) May even be automatically fixed on commit by git The missing newline could cause issues with some tools or make diffs less clean. Some projects consider this an important standard. While true, this is still a minor formatting issue that would be better handled by automated tools rather than manual review comments. The rules specifically say not to make purely informative comments. Delete this comment as it's too minor and informational rather than suggesting a clearly required code change.
Workflow ID: wflow_NdfTbS4X0lFYfrlL
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set MAX_THINKING_TOKENS to
32000in.claude/settings.jsonso we don't need to useultrathinkall the timedue to a change in claude / claude code where the model seems less willing to think spontaneously without ultrathink
Important
Set
MAX_THINKING_TOKENSto32000in.claude/settings.jsonto reduce reliance onultrathink.MAX_THINKING_TOKENSto32000in.claude/settings.jsonto reduce reliance onultrathink.ultrathink.This description was created by
for ad41c7d. You can customize this summary. It will automatically update as commits are pushed.