Keep Write tool diffs always expanded in conversation stream #757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, Write tool calls would collapse their diff view after approval, hiding the file changes from view. This was inconsistent with Edit tools which remain expanded throughout their lifecycle. Now Write tool diffs remain permanently visible regardless of approval or completion status, improving visibility of file changes and providing a consistent experience across all file modification tools. Fixes ENG-2275
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 9a94ed0 in 1 minute and 24 seconds. Click for details.
- Reviewed
72lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. humanlayer-wui/src/components/internal/ConversationStream/EventContent/WriteToolCallContent.tsx:27
- Draft comment:
Removed conditional logic (hasError, preview, showDiff) that previously provided error messaging and controlled diff rendering. Confirm this change is intentional and doesn't remove needed user feedback. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% The comment is asking for confirmation of intention, which violates the rule "Do NOT ask the PR author to confirm their intention". The comment is not making a clear assertion that the change is wrong, just asking if it's intentional. If there was a real issue with error handling, the comment should state that directly. Maybe the removal of error handling actually does cause real user experience issues that should be fixed? Even if there are UX issues, the comment should state them directly rather than asking for confirmation. Also, without seeing the broader application context, we can't be certain this is actually problematic. The comment should be deleted because it violates the rule against asking for confirmation of intention and doesn't make a clear assertion about what needs to be fixed.
2. humanlayer-wui/src/components/internal/ConversationStream/EventContent/WriteToolCallContent.tsx:17
- Draft comment:
Unused props (isCompleted, toolResultContent, isFocused) were removed from the function parameters. Ensure the related type definitions and overall component contract are updated accordingly. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_XnfdZhXPMXqbPSxI
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
balanceiskey
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem(s) was I solving?
Write tool calls in the Claude Code conversation stream would collapse their diff view immediately after approval, hiding the file changes from view. This was problematic because:
This issue was tracked as ENG-2275.
What user-facing changes did I ship?
How I implemented it
The fix was a targeted change to the
WriteToolCallContentcomponent:showDifffrom being conditional onapprovalStatusto always beingtrueformatToolResultPreview,detectToolError)hasError,preview,showDiff)isCompleted,toolResultContent,isFocused)DiffViewerThe implementation ensures the diff viewer is unconditionally rendered, providing permanent visibility of file changes.
How to verify it
Automated Testing
make -C humanlayer-wui checkmake -C humanlayer-wui lintmake -C humanlayer-wui testmake -C humanlayer-wui buildManual Testing
Description for the changelog
Keep Write tool diffs always expanded in conversation stream - file changes now remain visible throughout the entire tool lifecycle instead of collapsing after approval