fix: Replace Enter unicode character with 'ENTER' text in keyboard shortcuts #734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 21326fe in 53 seconds. Click for details.
- Reviewed
61lines of code in4files - Skipped
0files when reviewing. - Skipped posting
5draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. humanlayer-wui/src/components/CommandInput.tsx:309
- Draft comment:
Replaced ⏎ with 'ENTER' for consistency. Consider extracting the platform key logic (e.g., getPlatformKey) into a shared utility to minimize duplication across components. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. humanlayer-wui/src/components/OptInTelemetryModal.tsx:134
- Draft comment:
Updated the keyboard shortcut display by replacing ⏎ with 'ENTER'. Consider centralizing the platform check logic for consistency with other parts of the UI. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
3. humanlayer-wui/src/components/internal/SessionDetail/components/DenyButtons.tsx:15
- Draft comment:
Replaced ⏎ with 'ENTER' in the sendKey variable. The update improves clarity in the keyboard shortcut display. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
4. humanlayer-wui/src/components/internal/SessionDetail/components/ForkViewModal.tsx:456
- Draft comment:
Updated the shortcut label to use 'ENTER' instead of ⏎. This ensures consistent UI messaging. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
5. humanlayer-wui/src/components/internal/SessionDetail/components/ForkViewModal.tsx:466
- Draft comment:
Replaced ⏎ with 'ENTER' in the instructional text for forking. This update maintains consistency across shortcut displays. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_66ZmWJVABzitUf1l
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
…ortcuts - Changed all instances of ⏎ (U+23CE) to 'ENTER' text - Updated keyboard shortcut format from '⌘ ENTER' to '⌘+ENTER' for consistency - Affected components: OptInTelemetryModal, CommandInput, DenyButtons, ForkViewModal 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
21326fe to
c77eecd
Compare
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed c77eecd in 50 seconds. Click for details.
- Reviewed
63lines of code in4files - Skipped
0files when reviewing. - Skipped posting
5draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. humanlayer-wui/src/components/CommandInput.tsx:310
- Draft comment:
Updated shortcut text to 'ENTER' instead of using ⏎. Consider centralizing this string if reused. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. humanlayer-wui/src/components/OptInTelemetryModal.tsx:134
- Draft comment:
Standardized the keyboard shortcut text to 'ENTER' in the telemetry modal. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. humanlayer-wui/src/components/internal/SessionDetail/components/DenyButtons.tsx:15
- Draft comment:
Updated keyboard shortcut text to use 'ENTER' instead of ⏎ for consistency. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
4. humanlayer-wui/src/components/internal/SessionDetail/components/ForkViewModal.tsx:456
- Draft comment:
Replaced ⏎ with 'ENTER' in the fork session button shortcut for consistency. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
5. humanlayer-wui/src/components/internal/SessionDetail/components/ForkViewModal.tsx:465
- Draft comment:
Updated fork action label from '⌘⏎ Fork' to '⌘+ENTER Fork' for clarity. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_iq7V5BglJJIPR3NU
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem(s) was I solving?
The CodeLayer UI was inconsistently displaying keyboard shortcuts for the Enter key. The first-time modal (OptInTelemetryModal) and other UI components were using the Unicode character ⏎ (U+23CE) to represent the Enter key, while the standard practice across the codebase is to spell out "ENTER" as text. This created visual inconsistency and potential confusion for users.
Additionally, the keyboard shortcut format was inconsistent, sometimes showing
⌘ ENTER(with a space) instead of⌘+ENTER(with a plus sign), which is the standard notation for key combinations.What user-facing changes did I ship?
+symbol (e.g.,⌘+ENTERinstead of⌘ ENTER)How I implemented it
⏎characters to "ENTER" text⌘ ENTER→⌘+ENTER)Changes were made in 4 files:
humanlayer-wui/src/components/OptInTelemetryModal.tsxhumanlayer-wui/src/components/CommandInput.tsxhumanlayer-wui/src/components/internal/SessionDetail/components/DenyButtons.tsxhumanlayer-wui/src/components/internal/SessionDetail/components/ForkViewModal.tsxHow to verify it
Manual Testing
⌘+ENTERorCtrl+ENTER⌘+ENTERAutomated Testing
make check testto ensure no TypeScript errors or test failuresDescription for the changelog
fix: Standardize keyboard shortcut display to use "ENTER" text instead of Unicode character across all UI components